Use dot notation in some places

Summary: Use `x.y` in favor of `x['y']` in //some// JavaScript callsites. Note that there are a bunch of places where the latter is explicitly used to trick `PhabricatorJavelinLinter`.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11442

webroot/rsrc/externals/javelin/core/Stratcom.js

@@ -223,7 +223,7 @@ JX.install('Stratcom', {
       }
 
       // Add a remove function to the listener
-      listener['remove'] = function() {
+      listener.remove = function() {
         if (listener._callback) {
           delete listener._callback;
           for (var ii = 0; ii < ids.length; ii++) {

webroot/rsrc/externals/javelin/core/init.js

@@ -46,7 +46,7 @@
   makeHoldingQueue('behavior');
   makeHoldingQueue('install-init');
 
-  window['__DEV__'] = window['__DEV__'] || 0;
+  window.__DEV__ = window.__DEV__ || 0;
 
   var loaded = false;
   var onload = [];

webroot/rsrc/js/application/differential/behavior-show-more.js

@@ -40,8 +40,8 @@ JX.behavior('differential-show-more', function(config) {
       JX.DOM.setContent(container, 'Loading...');
       JX.DOM.alterClass(context, 'differential-show-more-loading', true);
 
-      if (!data['whitespace']) {
-        data['whitespace'] = config.whitespace;
+      if (!data.whitespace) {
+        data.whitespace = config.whitespace;
       }
 
       new JX.Workflow(config.uri, data)