archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Maniphest - load subscribers in getApplicationTransactionsObject

Browse Source 
Summary: Fixes T6734. This is a very generic fix, which basically attaches the subscribers if necessary. This seems like a good idea given there's some crazy generic code doing this sort of thing? This would end up being a new pattern for these types of objects that may be loaded by a general object query but then get some editor action against them.

Test Plan: I can't actually reproduce this in my sandbox so I'll verify live again.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6734

Differential Revision: https://secure.phabricator.com/D10976
This commit is contained in:
Bob Trahan
2014-12-11 11:30:33 -08:00
parent bc5598865f
commit dda8e64a3e
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
View File

@@ -139,7 +139,8 @@ final class HeraldManiphestTaskAdapter extends HeraldAdapter {
case self::FIELD_ASSIGNEE: case self::FIELD_ASSIGNEE:
return $this->getTask()->getOwnerPHID(); return $this->getTask()->getOwnerPHID();
case self::FIELD_CC: case self::FIELD_CC:
return $this->getTask()->getSubscriberPHIDs(); return PhabricatorSubscribersQuery::loadSubscribersForPHID(
$this->getTask()->getPHID());
case self::FIELD_PROJECTS: case self::FIELD_PROJECTS:
return PhabricatorEdgeQuery::loadDestinationPHIDs( return PhabricatorEdgeQuery::loadDestinationPHIDs(
$this->getTask()->getPHID(), $this->getTask()->getPHID(),