Pholio - support editing images - fixes T3489

Summary:
Nice title. We add three new transactions - IMAGE_FILE, IMAGE_NAME, and IMAGE_DESCRIPTION. The first is a bit like subscribers as it is a list of file phids. The latter have values of the form ($file_phid => $data), where $data is $name or $description respectively. This is because we need to collate transactions based on $file_phid...

Overall, this uses the _underyling files_ and not the "PholioImage" to determine if things are unique or not. That said, simply mark PholioImages as obsolete so inline comments about no-longer applicable PholioImages don't break.

Does a reasonable job implementing the mock. Note you can't "update" an image at this time, though you can delete and add at will.

Test Plan: played with pholio a ton.

Reviewers: epriestley

Reviewed By: epriestley

CC: chad, aran, Korvin

Maniphest Tasks: T3489

Differential Revision: https://secure.phabricator.com/D6441

src/applications/files/controller/PhabricatorFileDropUploadController.php

@@ -3,6 +3,20 @@
 final class PhabricatorFileDropUploadController
   extends PhabricatorFileController {
 
+  private $viewObject;
+
+  public function setViewObject(AphrontAbstractAttachedFileView $view) {
+    $this->viewObject = $view;
+    return $this;
+  }
+
+  public function getViewObject() {
+    if (!$this->viewObject) {
+      $this->viewObject = new AphrontAttachedFileView();
+    }
+    return $this->viewObject;
+  }
+
   /**
    * @phutil-external-symbol class PhabricatorStartup
    */
@@ -24,7 +38,7 @@ final class PhabricatorFileDropUploadController
         'isExplicitUpload' => true,
       ));
 
-    $view = new AphrontAttachedFileView();
+    $view = $this->getViewObject();
     $view->setFile($file);
 
     return id(new AphrontAjaxResponse())->setContent(