Use PHUIRemarkupPreviewView in Phame

Summary: Reuse PHUIMarkupPreviewView in Phame for consistency, less custom code. Also, doesn't work (JS issue).

Test Plan: New Post, Edit Post, Save Post

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14552
This commit is contained in:
Chad Little
2015-11-23 10:28:59 -08:00
parent a58c5e10b8
commit df7f21b4e8
7 changed files with 16 additions and 67 deletions

View File

@@ -50,7 +50,7 @@ final class PhabricatorPhameApplication extends PhabricatorApplication {
'publish/(?P<id>\d+)/' => 'PhamePostPublishController',
'unpublish/(?P<id>\d+)/' => 'PhamePostUnpublishController',
'notlive/(?P<id>\d+)/' => 'PhamePostNotLiveController',
'preview/' => 'PhamePostPreviewController',
'preview/' => 'PhabricatorMarkupPreviewController',
'framed/(?P<id>\d+)/' => 'PhamePostFramedController',
'new/' => 'PhamePostNewController',
'move/(?P<id>\d+)/' => 'PhamePostNewController',

View File

@@ -175,27 +175,17 @@ final class PhamePostEditController extends PhamePostController {
->addCancelButton($cancel_uri)
->setValue($submit_button));
$header = id(new PHUIHeaderView())
->setHeader(pht('%s (Post Preview)', $title));
$container = id(new PHUIBoxView())
->setID('post-preview');
$document = id(new PHUIDocumentViewPro())
->setHeader($header)
->appendChild($container);
$preview_panel = id(new PHUIObjectBoxView())
->appendChild($document);
$preview = id(new PHUIRemarkupPreviewPanel())
->setHeader($post->getTitle())
->setPreviewURI($this->getApplicationURI('post/preview/'))
->setControlID('post-body')
->setPreviewType(PHUIRemarkupPreviewPanel::DOCUMENT);
Javelin::initBehavior(
'phame-post-preview',
array(
'preview' => 'post-preview',
'body' => 'post-body',
'title' => 'post-title',
'phame_title' => 'post-phame-title',
'uri' => '/phame/post/preview/',
));
$form_box = id(new PHUIObjectBoxView())
@@ -214,7 +204,7 @@ final class PhamePostEditController extends PhamePostController {
->appendChild(
array(
$form_box,
$preview_panel,
$preview,
));
}

View File

@@ -1,26 +0,0 @@
<?php
final class PhamePostPreviewController extends PhamePostController {
protected function getSideNavFilter() {
return null;
}
public function handleRequest(AphrontRequest $request) {
$viewer = $request->getViewer();
$body = $request->getStr('body');
$post = id(new PhamePost())
->setBody($body);
$content = PhabricatorMarkupEngine::renderOneObject(
$post,
PhamePost::MARKUP_FIELD_BODY,
$viewer);
$content = phutil_tag_div('phabricator-remarkup', $content);
return id(new AphrontAjaxResponse())->setContent($content);
}
}