archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Improve <title> on Diffusion pages

Browse Source 
Test Plan:
Visit /rX123.
Visit /diffusion/X/.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D1463
This commit is contained in:
vrana
2012-01-20 13:27:32 -08:00
parent d5eaef9567
commit e142c7e26c
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/applications/diffusion/controller/commit/DiffusionCommitController.php
View File

@@ -192,8 +192,7 @@ class DiffusionCommitController extends DiffusionController {
$branch = $drequest->getBranchURIComponent( $branch = $drequest->getBranchURIComponent(
$drequest->getBranch()); $drequest->getBranch());
$filename = $changeset->getFilename(); $filename = $changeset->getFilename();
$commit = $drequest->getCommit(); $reference = "{$branch}{$filename};".$drequest->getCommit();
$reference = "{$branch}{$filename};{$commit}";
$references[$key] = $reference; $references[$key] = $reference;
} }
@@ -216,7 +215,7 @@ class DiffusionCommitController extends DiffusionController {
return $this->buildStandardPageResponse( return $this->buildStandardPageResponse(
$content, $content,
array( array(
'title' => 'Diffusion', 'title' => 'r'.$callsign.$commit->getCommitIdentifier(),
)); ));
} }

4
src/applications/diffusion/controller/repository/DiffusionRepositoryController.php
View File

@@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -106,7 +106,7 @@ class DiffusionRepositoryController extends DiffusionController {
return $this->buildStandardPageResponse( return $this->buildStandardPageResponse(
$content, $content,
array( array(
'title' => 'Diffusion', 'title' => $drequest->getRepository()->getName(),
)); ));
} }