Remove Controller->renderHandlesForPHIDs()
Summary: Ref T7689. Remove all remaining callsites for this method. Test Plan: - Viewed a custom policy; viewed handles in the policy rules. - Viewed a Releeph product; viewed "Pushers". - Viewed a project; viewed "Watchers"; viewed "Members"; viewed "Looks Like". - Viewed repository edit; viewed "Credential"; viewed "Storage Service"; viewed "Projects". - Viewed repository detail; viewed "Projects". - Viewed commit; viewed (faked) "Reverts"; viewed (faked) "Reverted By". - These are kind of a pain to generate so I faked 'em. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7689 Differential Revision: https://secure.phabricator.com/D12208
This commit is contained in:
@@ -265,8 +265,7 @@ final class DiffusionRepositoryEditMainController
|
||||
$repository->getPHID(),
|
||||
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
|
||||
if ($project_phids) {
|
||||
$this->loadHandles($project_phids);
|
||||
$project_text = $this->renderHandlesForPHIDs($project_phids);
|
||||
$project_text = $viewer->renderHandleList($project_phids);
|
||||
} else {
|
||||
$project_text = phutil_tag('em', array(), pht('None'));
|
||||
}
|
||||
@@ -546,10 +545,9 @@ final class DiffusionRepositoryEditMainController
|
||||
|
||||
$credential_phid = $repository->getCredentialPHID();
|
||||
if ($credential_phid) {
|
||||
$this->loadHandles(array($credential_phid));
|
||||
$view->addProperty(
|
||||
pht('Credential'),
|
||||
$this->getHandle($credential_phid)->renderLink());
|
||||
$viewer->renderHandle($credential_phid));
|
||||
}
|
||||
|
||||
return $view;
|
||||
@@ -584,8 +582,7 @@ final class DiffusionRepositoryEditMainController
|
||||
|
||||
$service_phid = $repository->getAlmanacServicePHID();
|
||||
if ($service_phid) {
|
||||
$handles = $this->loadViewerHandles(array($service_phid));
|
||||
$v_service = $handles[$service_phid]->renderLink();
|
||||
$v_service = $viewer->renderHandle($service_phid);
|
||||
} else {
|
||||
$v_service = phutil_tag(
|
||||
'em',
|
||||
|
||||
Reference in New Issue
Block a user