Remove Controller->renderHandlesForPHIDs()
Summary: Ref T7689. Remove all remaining callsites for this method. Test Plan: - Viewed a custom policy; viewed handles in the policy rules. - Viewed a Releeph product; viewed "Pushers". - Viewed a project; viewed "Watchers"; viewed "Members"; viewed "Looks Like". - Viewed repository edit; viewed "Credential"; viewed "Storage Service"; viewed "Projects". - Viewed repository detail; viewed "Projects". - Viewed commit; viewed (faked) "Reverts"; viewed (faked) "Reverted By". - These are kind of a pain to generate so I faked 'em. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7689 Differential Revision: https://secure.phabricator.com/D12208
This commit is contained in:
@@ -167,11 +167,6 @@ final class PhabricatorProjectProfileController
|
||||
$request = $this->getRequest();
|
||||
$viewer = $request->getUser();
|
||||
|
||||
$this->loadHandles(
|
||||
array_merge(
|
||||
$project->getMemberPHIDs(),
|
||||
$project->getWatcherPHIDs()));
|
||||
|
||||
$view = id(new PHUIPropertyListView())
|
||||
->setUser($viewer)
|
||||
->setObject($project)
|
||||
@@ -189,24 +184,26 @@ final class PhabricatorProjectProfileController
|
||||
$view->addProperty(
|
||||
pht('Members'),
|
||||
$project->getMemberPHIDs()
|
||||
? $this->renderHandlesForPHIDs($project->getMemberPHIDs(), ',')
|
||||
? $viewer
|
||||
->renderHandleList($project->getMemberPHIDs())
|
||||
->setAsInline(true)
|
||||
: phutil_tag('em', array(), pht('None')));
|
||||
|
||||
$view->addProperty(
|
||||
pht('Watchers'),
|
||||
$project->getWatcherPHIDs()
|
||||
? $this->renderHandlesForPHIDs($project->getWatcherPHIDs(), ',')
|
||||
? $viewer
|
||||
->renderHandleList($project->getWatcherPHIDs())
|
||||
->setAsInline(true)
|
||||
: phutil_tag('em', array(), pht('None')));
|
||||
|
||||
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
|
||||
$viewer,
|
||||
$project);
|
||||
|
||||
$this->loadHandles(array($project->getPHID()));
|
||||
|
||||
$view->addProperty(
|
||||
pht('Looks Like'),
|
||||
$this->getHandle($project->getPHID())->renderTag());
|
||||
$viewer->renderHandle($project->getPHID())->setAsTag(true));
|
||||
|
||||
$view->addProperty(
|
||||
pht('Joinable By'),
|
||||
|
||||
Reference in New Issue
Block a user