Remove Controller->renderHandlesForPHIDs()
Summary: Ref T7689. Remove all remaining callsites for this method. Test Plan: - Viewed a custom policy; viewed handles in the policy rules. - Viewed a Releeph product; viewed "Pushers". - Viewed a project; viewed "Watchers"; viewed "Members"; viewed "Looks Like". - Viewed repository edit; viewed "Credential"; viewed "Storage Service"; viewed "Projects". - Viewed repository detail; viewed "Projects". - Viewed commit; viewed (faked) "Reverts"; viewed (faked) "Reverted By". - These are kind of a pain to generate so I faked 'em. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7689 Differential Revision: https://secure.phabricator.com/D12208
This commit is contained in:
@@ -63,8 +63,6 @@ final class PhabricatorApplicationTransactionValueController
|
||||
$rule_objects[$class] = newv($class, array());
|
||||
}
|
||||
$policy->attachRuleObjects($rule_objects);
|
||||
$handle_phids = $this->extractPHIDs($policy, $rule_objects);
|
||||
$handles = $this->loadHandles($handle_phids);
|
||||
|
||||
$this->requireResource('policy-transaction-detail-css');
|
||||
$cancel_uri = $this->guessCancelURI($viewer, $xaction);
|
||||
@@ -114,13 +112,17 @@ final class PhabricatorApplicationTransactionValueController
|
||||
->setIconFont($icon)
|
||||
->setText(
|
||||
ucfirst($rule['action']).' '.$rule_object->getRuleDescription());
|
||||
$handle_phids =
|
||||
$rule_object->getRequiredHandlePHIDsForSummary($rule['value']);
|
||||
|
||||
$handle_phids = $rule_object->getRequiredHandlePHIDsForSummary(
|
||||
$rule['value']);
|
||||
if ($handle_phids) {
|
||||
$value = $this->renderHandlesForPHIDs($handle_phids, ',');
|
||||
$value = $this->getViewer()
|
||||
->renderHandleList($handle_phids)
|
||||
->setInline(true);
|
||||
} else {
|
||||
$value = $rule['value'];
|
||||
}
|
||||
|
||||
$details[] = phutil_tag('div',
|
||||
array(
|
||||
'class' => 'policy-transaction-detail-row',
|
||||
|
||||
Reference in New Issue
Block a user