In Differential, allow "r" to create comments and "R" to quote

Summary:
Ref T11401. Fixes T5232. Ref T12616.

Partly, this moves more code over to the new stuff.

This also allows "r" to work if you have code selected (not just comments). If you "reply" to code, you start a new comment.

You can "R" a comment to quote it. This just starts a new comment normally if you "R" a block of code. This is sort of a power-user version of "quote" since it seems like it probably doesn't really make sense to put it in the UI ever (maybe).

With the new click-to-select, you can click + "R" to reply-with-quote.

Test Plan: Used "r" and "R" to reply to comments and code.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616, T11401, T5232

Differential Revision: https://secure.phabricator.com/D17920

webroot/rsrc/js/application/diff/DiffChangeset.js

@@ -526,7 +526,37 @@ JX.install('DiffChangeset', {
       return data.inline;
     },
 
-    newInlineForRange: function(data) {
+    newInlineForRange: function(origin, target) {
+      var list = this.getChangesetList();
+
+      var src = list.getLineNumberFromHeader(origin);
+      var dst = list.getLineNumberFromHeader(target);
+
+      var changeset_id = null;
+      var side = list.getDisplaySideFromHeader(origin);
+      if (side == 'right') {
+        changeset_id = this.getRightChangesetID();
+      } else {
+        changeset_id = this.getLeftChangesetID();
+      }
+
+      var is_new = false;
+      if (side == 'right') {
+        is_new = true;
+      } else if (this.getRightChangesetID() != this.getLeftChangesetID()) {
+        is_new = true;
+      }
+
+      var data = {
+        origin: origin,
+        target: target,
+        number: src,
+        length: dst - src,
+        changesetID: changeset_id,
+        displaySide: side,
+        isNewFile: is_new
+      };
+
       var inline = new JX.DiffInline()
         .setChangeset(this)
         .bindToRange(data);
@@ -538,14 +568,14 @@ JX.install('DiffChangeset', {
       return inline;
     },
 
-    newInlineReply: function(original) {
+    newInlineReply: function(original, text) {
       var inline = new JX.DiffInline()
         .setChangeset(this)
         .bindToReply(original);
 
       this._inlines.push(inline);
 
-      inline.create();
+      inline.create(text);
 
       return inline;
     },