Show only recent open revisions affecting the same files
Summary: Fixes T5658. Over a long period of time, some cruft can build up here. Only show revisions which have been updated in the last 30 days. Test Plan: - Viewed panel in Differential and Diffusion. - Changed limit from 30 days to 30 seconds and saw no revisions. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5658 Differential Revision: https://secure.phabricator.com/D12158
This commit is contained in:
@@ -780,9 +780,12 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
||||
return array();
|
||||
}
|
||||
|
||||
$recent = (PhabricatorTime::getNow() - phutil_units('30 days in seconds'));
|
||||
|
||||
$query = id(new DifferentialRevisionQuery())
|
||||
->setViewer($this->getRequest()->getUser())
|
||||
->withStatus(DifferentialRevisionQuery::STATUS_OPEN)
|
||||
->withUpdatedEpochBetween($recent, null)
|
||||
->setOrder(DifferentialRevisionQuery::ORDER_PATH_MODIFIED)
|
||||
->setLimit(10)
|
||||
->needFlags(true)
|
||||
@@ -807,13 +810,17 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
||||
|
||||
private function renderOtherRevisions(array $revisions) {
|
||||
assert_instances_of($revisions, 'DifferentialRevision');
|
||||
$viewer = $this->getViewer();
|
||||
|
||||
$user = $this->getRequest()->getUser();
|
||||
$header = id(new PHUIHeaderView())
|
||||
->setHeader(pht('Similar Open Revisions'))
|
||||
->setSubheader(
|
||||
pht('Recently updated open revisions affecting the same files.'));
|
||||
|
||||
$view = id(new DifferentialRevisionListView())
|
||||
->setHeader(pht('Open Revisions Affecting These Files'))
|
||||
->setHeader($header)
|
||||
->setRevisions($revisions)
|
||||
->setUser($user);
|
||||
->setUser($viewer);
|
||||
|
||||
$phids = $view->getRequiredHandlePHIDs();
|
||||
$handles = $this->loadViewerHandles($phids);
|
||||
|
||||
Reference in New Issue
Block a user