[Redesign] Remove PHUIActionHeaderView
Summary: This adds minor functionality to PHUIHeaderView (icons, tags) that were previously on in ActionHeader. This allows us to remove the PHUIActionHeaderView outright in favor of just one Header class. Test Plan: Tested each callsite, workboards, hovercards, conpherence. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12902
This commit is contained in:
@@ -362,7 +362,7 @@ final class PhabricatorProjectBoardViewController
|
||||
$project->getName());
|
||||
|
||||
$header = id(new PHUIHeaderView())
|
||||
->setHeader(pht('%s Workboard', $header_link))
|
||||
->setHeader($header_link)
|
||||
->setUser($viewer)
|
||||
->setNoBackground(true)
|
||||
->addActionLink($sort_menu)
|
||||
@@ -370,12 +370,16 @@ final class PhabricatorProjectBoardViewController
|
||||
->addActionLink($manage_menu)
|
||||
->setPolicyObject($project);
|
||||
|
||||
$header_box = id(new PHUIBoxView())
|
||||
->appendChild($header)
|
||||
->addClass('project-board-header');
|
||||
|
||||
$board_box = id(new PHUIBoxView())
|
||||
->appendChild($board)
|
||||
->addClass('project-board-wrapper');
|
||||
|
||||
$nav = $this->buildIconNavView($project);
|
||||
$nav->appendChild($header);
|
||||
$nav->appendChild($header_box);
|
||||
$nav->appendChild($board_box);
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
@@ -674,7 +678,7 @@ final class PhabricatorProjectBoardViewController
|
||||
}
|
||||
|
||||
$column_button = id(new PHUIIconView())
|
||||
->setIconFont('fa-caret-down')
|
||||
->setIconFont('fa-gear')
|
||||
->setHref('#')
|
||||
->addSigil('boards-dropdown-menu')
|
||||
->setMetadata(
|
||||
|
||||
Reference in New Issue
Block a user