Don't trigger audits for archived packages
Summary:
Ref T10939. This is just a bug. I thought this was what was described in T10174 but that's actually talking about something completely different.
Also make a `<select />` slightly easier to use.
Test Plan:
- Created a package with auditing enabled.
- Pushed a change.
- Saw audit trigger.
- Disabled the package, pushed a change.
- Before patch: saw audit trigger improperly.
- After patch: restarted daemons, then saw audit correctly not trigger.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10939
Differential Revision: https://secure.phabricator.com/D15907
This commit is contained in:
@@ -82,7 +82,7 @@ final class PhabricatorOwnersPathsController
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
$repos = mpull($repos, 'getMonogram', 'getPHID');
|
$repos = mpull($repos, 'getDisplayName', 'getPHID');
|
||||||
asort($repos);
|
asort($repos);
|
||||||
|
|
||||||
$template = new AphrontTypeaheadTemplateView();
|
$template = new AphrontTypeaheadTemplateView();
|
||||||
|
|||||||
@@ -51,6 +51,11 @@ final class PhabricatorRepositoryCommitOwnersWorker
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if ($package->isArchived()) {
|
||||||
|
// Don't trigger audits if the package is archived.
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
if ($package->getAuditingEnabled()) {
|
if ($package->getAuditingEnabled()) {
|
||||||
$reasons = $this->checkAuditReasons($commit, $package);
|
$reasons = $this->checkAuditReasons($commit, $package);
|
||||||
if ($reasons) {
|
if ($reasons) {
|
||||||
|
|||||||
Reference in New Issue
Block a user