Pass viewer to all ManiphestTaskQuery objects

Summary: Ref T603. Prepare for conversion to a policy-aware query.

Test Plan: Browsed various interfaces which use this stuff.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6928

src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php

@@ -227,6 +227,7 @@ abstract class DifferentialFreeformFieldSpecification
     }
 
     $tasks = id(new ManiphestTaskQuery())
+      ->setViewer($user)
       ->withTaskIDs(array_keys($tasks_statuses))
       ->execute();
 

src/applications/directory/controller/PhabricatorDirectoryMainController.php

@@ -98,12 +98,12 @@ final class PhabricatorDirectoryMainController
 
   private function buildUnbreakNowPanel() {
     $user = $this->getRequest()->getUser();
-    $user_phid = $user->getPHID();
 
-    $task_query = new ManiphestTaskQuery();
+    $task_query = id(new ManiphestTaskQuery())
-    $task_query->withStatus(ManiphestTaskQuery::STATUS_OPEN);
+      ->setViewer($user)
-    $task_query->withPriority(ManiphestTaskPriority::PRIORITY_UNBREAK_NOW);
+      ->withStatus(ManiphestTaskQuery::STATUS_OPEN)
-    $task_query->setLimit(10);
+      ->withPriority(ManiphestTaskPriority::PRIORITY_UNBREAK_NOW)
+      ->setLimit(10);
 
     $tasks = $task_query->execute();
 
@@ -135,14 +135,14 @@ final class PhabricatorDirectoryMainController
     assert_instances_of($projects, 'PhabricatorProject');
 
     $user = $this->getRequest()->getUser();
-    $user_phid = $user->getPHID();
 
     if ($projects) {
-      $task_query = new ManiphestTaskQuery();
+      $task_query = id(new ManiphestTaskQuery())
-      $task_query->withStatus(ManiphestTaskQuery::STATUS_OPEN);
+        ->setViewer($user)
-      $task_query->withPriority(ManiphestTaskPriority::PRIORITY_TRIAGE);
+        ->withStatus(ManiphestTaskQuery::STATUS_OPEN)
-      $task_query->withAnyProjects(mpull($projects, 'getPHID'));
+        ->withPriority(ManiphestTaskPriority::PRIORITY_TRIAGE)
-      $task_query->setLimit(10);
+        ->withAnyProjects(mpull($projects, 'getPHID'))
+        ->setLimit(10);
       $tasks = $task_query->execute();
     } else {
       $tasks = array();
@@ -249,11 +249,12 @@ final class PhabricatorDirectoryMainController
     $user = $this->getRequest()->getUser();
     $user_phid = $user->getPHID();
 
-    $task_query = new ManiphestTaskQuery();
+    $task_query = id(new ManiphestTaskQuery())
-    $task_query->withStatus(ManiphestTaskQuery::STATUS_OPEN);
+      ->setViewer($user)
-    $task_query->setGroupBy(ManiphestTaskQuery::GROUP_PRIORITY);
+      ->withStatus(ManiphestTaskQuery::STATUS_OPEN)
-    $task_query->withOwners(array($user_phid));
+      ->setGroupBy(ManiphestTaskQuery::GROUP_PRIORITY)
-    $task_query->setLimit(10);
+      ->withOwners(array($user_phid))
+      ->setLimit(10);
 
     $tasks = $task_query->execute();
 

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

@@ -83,6 +83,7 @@ final class PhabricatorApplicationManiphest extends PhabricatorApplication {
     $status = array();
 
     $query = id(new ManiphestTaskQuery())
+      ->setViewer($user)
       ->withStatus(ManiphestTaskQuery::STATUS_OPEN)
       ->withPriority(ManiphestTaskPriority::PRIORITY_UNBREAK_NOW)
       ->setLimit(1)
@@ -97,6 +98,7 @@ final class PhabricatorApplicationManiphest extends PhabricatorApplication {
       ->setCount($count);
 
     $query = id(new ManiphestTaskQuery())
+      ->setViewer($user)
       ->withStatus(ManiphestTaskQuery::STATUS_OPEN)
       ->withOwners(array($user->getPHID()))
       ->setLimit(1)

src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php

@@ -65,6 +65,8 @@ class ConduitAPI_maniphest_query_Method
   protected function execute(ConduitAPIRequest $request) {
     $query = new ManiphestTaskQuery();
 
+    $query->setViewer($request->getUser());
+
     $task_ids = $request->getValue('ids');
     if ($task_ids) {
       $query->withTaskIDs($task_ids);

src/applications/maniphest/controller/ManiphestReportController.php

@@ -386,6 +386,7 @@ final class ManiphestReportController extends ManiphestController {
 
 
     $query = id(new ManiphestTaskQuery())
+      ->setViewer($user)
       ->withStatus(ManiphestTaskQuery::STATUS_OPEN);
 
     $project_phid = $request->getStr('project');

src/applications/maniphest/controller/ManiphestTaskListController.php

@@ -459,6 +459,7 @@ final class ManiphestTaskListController extends ManiphestController {
       ManiphestTaskPriority::getHighestPriority());
 
     $query = new ManiphestTaskQuery();
+    $query->setViewer($viewer);
     $query->withTaskIDs($task_ids);
 
     if ($project_phids) {

src/applications/project/controller/PhabricatorProjectProfileController.php

@@ -154,6 +154,7 @@ final class PhabricatorProjectProfileController
     $user = $this->getRequest()->getUser();
 
     $query = id(new ManiphestTaskQuery())
+      ->setViewer($user)
       ->withAnyProjects(array($project->getPHID()))
       ->withStatus(ManiphestTaskQuery::STATUS_OPEN)
       ->setOrderBy(ManiphestTaskQuery::ORDER_PRIORITY)