Fix 'Add to Dashboard' issue with builtins
Summary: Ref T5307. Actually check the built in query with query, not engine. Test Plan: Try a builtin query, and a custom query when making a dashboard panel. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T5307 Differential Revision: https://secure.phabricator.com/D17521
This commit is contained in:
@@ -29,7 +29,7 @@ final class PhabricatorDashboardQueryPanelInstallController
|
|||||||
$engine = $engines[$v_engine];
|
$engine = $engines[$v_engine];
|
||||||
$engine->setViewer($viewer);
|
$engine->setViewer($viewer);
|
||||||
$good_query = false;
|
$good_query = false;
|
||||||
if ($engine->isBuiltinQuery($v_engine)) {
|
if ($engine->isBuiltinQuery($v_query)) {
|
||||||
$good_query = true;
|
$good_query = true;
|
||||||
} else {
|
} else {
|
||||||
$saved_query = id(new PhabricatorSavedQueryQuery())
|
$saved_query = id(new PhabricatorSavedQueryQuery())
|
||||||
|
|||||||
Reference in New Issue
Block a user