archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix method visibility for PhabricatorController subclasses

Browse Source 
Summary: Ref T6822.

Test Plan: Visual inspection. These methods are only called from within `PhabricatorController` subclasses.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11241
This commit is contained in:
Joshua Spence
2015-01-07 07:34:58 +11:00
parent e448386d39
commit e7f8e79742
59 changed files with 73 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/almanac/controller/AlmanacDeviceController.php
View File

@@ -2,7 +2,7 @@
abstract class AlmanacDeviceController extends AlmanacController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$list_uri = $this->getApplicationURI('device/');

2
src/applications/almanac/controller/AlmanacDeviceListController.php
View File

@@ -16,7 +16,7 @@ final class AlmanacDeviceListController
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/almanac/controller/AlmanacNetworkController.php
View File

@@ -2,7 +2,7 @@
abstract class AlmanacNetworkController extends AlmanacController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$list_uri = $this->getApplicationURI('network/');

2
src/applications/almanac/controller/AlmanacNetworkListController.php
View File

@@ -16,7 +16,7 @@ final class AlmanacNetworkListController
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/almanac/controller/AlmanacServiceController.php
View File

@@ -2,7 +2,7 @@
abstract class AlmanacServiceController extends AlmanacController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$list_uri = $this->getApplicationURI('service/');

2
src/applications/almanac/controller/AlmanacServiceListController.php
View File

@@ -16,7 +16,7 @@ final class AlmanacServiceListController
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/audit/controller/PhabricatorAuditController.php
View File

@@ -18,7 +18,7 @@ abstract class PhabricatorAuditController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}

2
src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
View File

@@ -20,7 +20,7 @@ abstract class PhabricatorAuthProviderConfigController
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu();
}

4
src/applications/calendar/controller/PhabricatorCalendarController.php
View File

@@ -20,11 +20,11 @@ abstract class PhabricatorCalendarController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/config/controller/PhabricatorConfigController.php
View File

@@ -26,7 +26,7 @@ abstract class PhabricatorConfigController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(null, true)->getMenu();
}

4
src/applications/conpherence/controller/ConpherenceController.php
View File

@@ -4,7 +4,7 @@ abstract class ConpherenceController extends PhabricatorController {
private $conpherences;
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
$nav = new PHUIListView();
$nav->newLink(
@@ -30,7 +30,7 @@ abstract class ConpherenceController extends PhabricatorController {
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs

4
src/applications/countdown/controller/PhabricatorCountdownController.php
View File

@@ -21,11 +21,11 @@ abstract class PhabricatorCountdownController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/dashboard/controller/PhabricatorDashboardListController.php
View File

@@ -39,7 +39,7 @@ final class PhabricatorDashboardListController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php
View File

@@ -36,7 +36,7 @@ final class PhabricatorDashboardPanelListController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Panels'), $this->getApplicationURI().'panel/');

2
src/applications/dashboard/controller/PhabricatorDashboardViewController.php
View File

@@ -49,7 +49,7 @@ final class PhabricatorDashboardViewController
));
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$id = $this->id;

4
src/applications/differential/controller/DifferentialController.php
View File

@@ -2,7 +2,7 @@
abstract class DifferentialController extends PhabricatorController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
@@ -29,7 +29,7 @@ abstract class DifferentialController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}

2
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
View File

@@ -3,7 +3,7 @@
abstract class DiffusionRepositoryEditController
extends DiffusionController {
public function buildApplicationCrumbs($is_main = false) {
protected function buildApplicationCrumbs($is_main = false) {
$crumbs = parent::buildApplicationCrumbs();
if ($this->diffusionRequest) {

2
src/applications/diffusion/controller/DiffusionRepositoryListController.php
View File

@@ -37,7 +37,7 @@ final class DiffusionRepositoryListController extends DiffusionController {
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/drydock/controller/DrydockBlueprintController.php
View File

@@ -16,7 +16,7 @@ abstract class DrydockBlueprintController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Blueprints'),

2
src/applications/drydock/controller/DrydockBlueprintListController.php
View File

@@ -22,7 +22,7 @@ final class DrydockBlueprintListController extends DrydockBlueprintController {
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$can_create = $this->hasApplicationCapability(
DrydockCreateBlueprintsCapability::CAPABILITY);

2
src/applications/drydock/controller/DrydockController.php
View File

@@ -4,7 +4,7 @@ abstract class DrydockController extends PhabricatorController {
abstract function buildSideNavView();
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}

2
src/applications/drydock/controller/DrydockLeaseController.php
View File

@@ -16,7 +16,7 @@ abstract class DrydockLeaseController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Leases'),

2
src/applications/drydock/controller/DrydockLogController.php
View File

@@ -16,7 +16,7 @@ abstract class DrydockLogController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Logs'),

2
src/applications/drydock/controller/DrydockResourceController.php
View File

@@ -16,7 +16,7 @@ abstract class DrydockResourceController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Resources'),

2
src/applications/files/controller/PhabricatorFileListController.php
View File

@@ -21,7 +21,7 @@ final class PhabricatorFileListController extends PhabricatorFileController {
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
id(new PHUIListItemView())

2
src/applications/fund/controller/FundInitiativeListController.php
View File

@@ -40,7 +40,7 @@ final class FundInitiativeListController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/harbormaster/controller/HarbormasterBuildableListController.php
View File

@@ -39,7 +39,7 @@ final class HarbormasterBuildableListController extends HarbormasterController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}

2
src/applications/harbormaster/controller/HarbormasterController.php
View File

@@ -2,7 +2,7 @@
abstract class HarbormasterController extends PhabricatorController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/harbormaster/controller/HarbormasterPlanController.php
View File

@@ -2,7 +2,7 @@
abstract class HarbormasterPlanController extends HarbormasterController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(

2
src/applications/harbormaster/controller/HarbormasterPlanListController.php
View File

@@ -40,7 +40,7 @@ final class HarbormasterPlanListController extends HarbormasterPlanController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}

4
src/applications/herald/controller/HeraldController.php
View File

@@ -16,11 +16,11 @@ abstract class HeraldController extends PhabricatorController {
return $response->setContent($page->render());
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/herald/controller/HeraldTranscriptListController.php
View File

@@ -23,7 +23,7 @@ final class HeraldTranscriptListController extends HeraldController {
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(

2
src/applications/legalpad/controller/LegalpadController.php
View File

@@ -22,7 +22,7 @@ abstract class LegalpadController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNav(true)->getMenu();
}

2
src/applications/legalpad/controller/LegalpadDocumentListController.php
View File

@@ -21,7 +21,7 @@ final class LegalpadDocumentListController extends LegalpadController {
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php
View File

@@ -64,7 +64,7 @@ final class LegalpadDocumentSignatureListController extends LegalpadController {
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
if ($this->document) {

2
src/applications/macro/controller/PhabricatorMacroController.php
View File

@@ -20,7 +20,7 @@ abstract class PhabricatorMacroController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu();
}

4
src/applications/mailinglists/controller/PhabricatorMailingListsController.php
View File

@@ -21,11 +21,11 @@ abstract class PhabricatorMailingListsController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/meta/controller/PhabricatorApplicationsController.php
View File

@@ -17,7 +17,7 @@ abstract class PhabricatorApplicationsController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}

2
src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
View File

@@ -22,7 +22,7 @@ final class PhabricatorOAuthClientListController
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/owners/controller/PhabricatorOwnersController.php
View File

@@ -58,7 +58,7 @@ abstract class PhabricatorOwnersController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}

4
src/applications/passphrase/controller/PassphraseController.php
View File

@@ -21,11 +21,11 @@ abstract class PassphraseController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

4
src/applications/paste/controller/PhabricatorPasteController.php
View File

@@ -21,11 +21,11 @@ abstract class PhabricatorPasteController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

4
src/applications/people/controller/PhabricatorPeopleController.php
View File

@@ -28,11 +28,11 @@ abstract class PhabricatorPeopleController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$viewer = $this->getRequest()->getUser();

2
src/applications/phame/controller/PhameController.php
View File

@@ -103,7 +103,7 @@ abstract class PhameController extends PhabricatorController {
return $stories;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->renderSideNavFilterView()->getMenu();
}

4
src/applications/pholio/controller/PholioController.php
View File

@@ -21,7 +21,7 @@ abstract class PholioController extends PhabricatorController {
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
@@ -33,7 +33,7 @@ abstract class PholioController extends PhabricatorController {
return $crumbs;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}

2
src/applications/phortune/controller/PhortuneCartListController.php
View File

@@ -79,7 +79,7 @@ final class PhortuneCartListController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$merchant = $this->merchant;

2
src/applications/phortune/controller/PhortuneChargeListController.php
View File

@@ -61,7 +61,7 @@ final class PhortuneChargeListController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$account = $this->account;

2
src/applications/phortune/controller/PhortuneMerchantController.php
View File

@@ -3,7 +3,7 @@
abstract class PhortuneMerchantController
extends PhortuneController {
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Merchants'),

2
src/applications/phortune/controller/PhortuneMerchantListController.php
View File

@@ -37,7 +37,7 @@ final class PhortuneMerchantListController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

4
src/applications/phriction/controller/PhrictionController.php
View File

@@ -22,11 +22,11 @@ abstract class PhrictionController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
if (get_class($this) != 'PhrictionListController') {

2
src/applications/ponder/controller/PonderController.php
View File

@@ -17,7 +17,7 @@ abstract class PonderController extends PhabricatorController {
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs
->addAction(

4
src/applications/project/controller/PhabricatorProjectListController.php
View File

@@ -22,11 +22,11 @@ final class PhabricatorProjectListController
return $this->delegateToController($controller);
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(

2
src/applications/releeph/controller/ReleephController.php
View File

@@ -34,7 +34,7 @@ abstract class ReleephController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}

2
src/applications/releeph/controller/branch/ReleephBranchViewController.php
View File

@@ -103,7 +103,7 @@ final class ReleephBranchViewController extends ReleephBranchController
->setViewer($this->getRequest()->getUser());
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$branch = $this->getBranch();

2
src/applications/releeph/controller/product/ReleephProductListController.php
View File

@@ -21,7 +21,7 @@ final class ReleephProductListController extends ReleephController {
return $this->delegateToController($controller);
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

2
src/applications/releeph/controller/product/ReleephProductViewController.php
View File

@@ -148,7 +148,7 @@ final class ReleephProductViewController extends ReleephProductController
return $nav;
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$product = $this->getProduct();

2
src/applications/settings/controller/PhabricatorSettingsMainController.php
View File

@@ -151,7 +151,7 @@ final class PhabricatorSettingsMainController
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
$panels = $this->buildPanels();
return $this->renderSideNav($panels)->getMenu();
}

4
src/applications/slowvote/controller/PhabricatorSlowvoteController.php
View File

@@ -22,11 +22,11 @@ abstract class PhabricatorSlowvoteController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(

5
src/applications/tokens/controller/PhabricatorTokenController.php
View File

@@ -2,7 +2,6 @@
abstract class PhabricatorTokenController extends PhabricatorController {
protected function buildSideNav() {
$nav = new AphrontSideNavFilterView();
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
@@ -14,11 +13,11 @@ abstract class PhabricatorTokenController extends PhabricatorController {
return $nav;
}
public function buildApplicationMenu() {
protected function buildApplicationMenu() {
return $this->buildSideNav()->getMenu();
}
public function buildApplicationCrumbs() {
protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
return $crumbs;
}