Remove some old page rendering code from Diffusion

Summary: Get rid of remaining callsites for buildStandardPageResponse() and modernize the UIs.

Test Plan: Looked at branches, tags, and commit detail pages.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7062

src/applications/diffusion/controller/DiffusionBranchTableController.php

@@ -2,6 +2,10 @@
 
 final class DiffusionBranchTableController extends DiffusionController {
 
+  public function shouldAllowPublic() {
+    return true;
+  }
+
   public function processRequest() {
     $drequest = $this->getDiffusionRequest();
     $request = $this->getRequest();
@@ -44,19 +48,21 @@ final class DiffusionBranchTableController extends DiffusionController {
         ->setDiffusionRequest($drequest);
 
       $panel = id(new AphrontPanelView())
-        ->setHeader(pht('Branches'))
+        ->setNoBackground(true)
         ->appendChild($view)
         ->appendChild($pager);
 
       $content = $panel;
     }
 
-    return $this->buildStandardPageResponse(
+    $crumbs = $this->buildCrumbs(
       array(
-        $this->buildCrumbs(
-          array(
-            'branches'    => true,
-          )),
+        'branches'    => true,
+      ));
+
+    return $this->buildApplicationPage(
+      array(
+        $crumbs,
         $content,
       ),
       array(