archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix permission check for "Create Task" on workboards

Browse Source 
Summary: Fixes T9090. You don't need to be able to edit a project to create tasks on its workboard. Being able to view the project is sufficient, and the user certianly can if they got this far.

Test Plan: Viewed workboard, hit "Create Task".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9090

Differential Revision: https://secure.phabricator.com/D14015
This commit is contained in:
epriestley
2015-08-31 10:17:37 -07:00
parent 51c52f50fd
commit e9614df76e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/applications/project/controller/PhabricatorProjectBoardViewController.php
View File

@@ -624,8 +624,7 @@ final class PhabricatorProjectBoardViewController
->setMetadata( ->setMetadata(
array( array(
'columnPHID' => $column->getPHID(), 'columnPHID' => $column->getPHID(),
)) ));
->setDisabled(!$can_edit);
$batch_edit_uri = $request->getRequestURI(); $batch_edit_uri = $request->getRequestURI();
$batch_edit_uri->setQueryParam('batch', $column->getID()); $batch_edit_uri->setQueryParam('batch', $column->getID());