Make "New Conversation" a workflow dialog in Conpherence

Summary: Ref T2416. My actual goal here is to stop having two places where we call the "load and display a list of threads" logic, but this is generally weird and no longer necessary with drag-and-drop-to-upload-remarkup.

Test Plan: {F37992}

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2416

Differential Revision: https://secure.phabricator.com/D5475
This commit is contained in:
epriestley
2013-03-31 12:44:12 -07:00
parent 89b75c72fd
commit e9fe1f4beb
2 changed files with 24 additions and 53 deletions

View File

@@ -105,10 +105,14 @@ abstract class ConpherenceController extends PhabricatorController {
$nav->setMenuID('conpherence-menu');
if (!$for_application) {
$nav->addButton(
'new',
pht('New Conversation'),
$this->getApplicationURI('new/'));
$nav->addMenuItem(
id(new PhabricatorMenuItemView())
->setName(pht('New Conversation'))
->setWorkflow(true)
->setKey('new')
->setHref($this->getApplicationURI('new/'))
->setType(PhabricatorMenuItemView::TYPE_BUTTON));
$nav->addLabel(pht('Unread'));
$nav = $this->addConpherencesToNav(
$unread_conpherences,