archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix a qsprintf() issue in mail queries

Browse Source 
Summary: Ref T920. Bumped into this while looking at SMS support.

Test Plan: Loaded `/mail/`, no more `qsprintf()` warning.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T920

Differential Revision: https://secure.phabricator.com/D19936
This commit is contained in:
epriestley
2018-12-30 10:54:06 -08:00
parent 106e90dcf0
commit ea8be11add
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
View File

@@ -99,8 +99,8 @@ final class PhabricatorMetaMTAMailQuery
return $where; return $where;
} }
protected function buildJoinClause(AphrontDatabaseConnection $conn) { protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
$joins = array(); $joins = parent::buildJoinClauseParts($conn);
if ($this->actorPHIDs === null && $this->recipientPHIDs === null) { if ($this->actorPHIDs === null && $this->recipientPHIDs === null) {
$joins[] = qsprintf( $joins[] = qsprintf(
@@ -119,7 +119,7 @@ final class PhabricatorMetaMTAMailQuery
PhabricatorMetaMTAMailHasRecipientEdgeType::EDGECONST); PhabricatorMetaMTAMailHasRecipientEdgeType::EDGECONST);
} }
return implode(' ', $joins); return $joins;
} }
protected function getPrimaryTableAlias() { protected function getPrimaryTableAlias() {