archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Better error messages for nonexistent CCs, reviewers, etc. in arc

Browse Source 
Summary:
The existing message is confusing and might cause people to think
that there is something wrong in the field name, e.g., 'CC' instead
of the value.

Test Plan:
Tested by putting random crap in CC and Reviewers and made sure the
error message was using the new format.

Reviewed By: jungejason
Reviewers: epriestley, jungejason
CC: mdevine, jungejason
Differential Revision: 145
This commit is contained in:
tuomaspelkonen
2011-04-15 14:31:54 -07:00
parent 825748586b
commit ebdcedc87f
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php
View File

@@ -240,7 +240,7 @@ class DifferentialCommitMessage {
$phid = idx($users, $name); $phid = idx($users, $name);
if (!$phid) { if (!$phid) {
throw new DifferentialCommitMessageParserException( throw new DifferentialCommitMessageParserException(
"Commit message references nonexistent 'Reviewer': ".$name); "Commit message references nonexistent 'Reviewer' value '".$name."'");
} }
$reviewer_phids[] = $phid; $reviewer_phids[] = $phid;
} }
@@ -251,7 +251,8 @@ class DifferentialCommitMessage {
$phid = idx($users, $name); $phid = idx($users, $name);
if (!$phid) { if (!$phid) {
throw new DifferentialCommitMessageParserException( throw new DifferentialCommitMessageParserException(
"Commit message references nonexistent 'Reviewed by': ".$name); "Commit message references nonexistent 'Reviewed by' value '".
$name."'");
} }
$reviewed_by_phids[] = $phid; $reviewed_by_phids[] = $phid;
} }
@@ -265,7 +266,7 @@ class DifferentialCommitMessage {
} }
if (!$phid) { if (!$phid) {
throw new DifferentialCommitMessageParserException( throw new DifferentialCommitMessageParserException(
"Commit message references nonexistent 'CC': ".$name); "Commit message references nonexistent 'CC' value '".$name."'");
} }
$cc_phids[] = $phid; $cc_phids[] = $phid;
} }