archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Avoid fatal error if there's no Arcanist project or repository

Browse Source 
Test Plan: Display diff without repository

Reviewers: nh, epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2373
This commit is contained in:
vrana
2012-05-02 17:26:09 -07:00
parent fd3d510dc8
commit ec068ff453
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/applications/differential/field/specification/revisionstatus/DifferentialRevisionStatusFieldSpecification.php
View File

@@ -35,6 +35,9 @@ final class DifferentialRevisionStatusFieldSpecification
$info = null; $info = null;
$local_vcs = $diff->getSourceControlSystem(); $local_vcs = $diff->getSourceControlSystem();
$backing_vcs = $diff->getBackingVersionControlSystem(); $backing_vcs = $diff->getBackingVersionControlSystem();
if (!$backing_vcs) {
$backing_vcs = $local_vcs;
}
if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) { if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) {
if ($local_vcs == $backing_vcs) { if ($local_vcs == $backing_vcs) {

3
src/applications/differential/storage/diff/DifferentialDiff.php
View File

@@ -91,6 +91,9 @@ final class DifferentialDiff extends DifferentialDAO {
return null; return null;
} }
$repository = $arcanist_project->loadRepository(); $repository = $arcanist_project->loadRepository();
if (!$repository) {
return null;
}
return $repository->getVersionControlSystem(); return $repository->getVersionControlSystem();
} }