archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Add a couple of missing needProperties() Almanac calls

Browse Source 
Summary: Fixes T10432. I missed these in making properties non-default.

Test Plan: Diffusion now works again in a cluster configuration.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10432

Differential Revision: https://secure.phabricator.com/D15337
This commit is contained in:
epriestley
2016-02-23 13:44:12 -08:00
parent 76d4e85bfc
commit ee6070a984
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
View File

@@ -51,6 +51,7 @@ final class DiffusionRepositoryCreateController
array( array(
'AlmanacClusterRepositoryServiceType', 'AlmanacClusterRepositoryServiceType',
)) ))
->needProperties(true)
->execute(); ->execute();
if ($services) { if ($services) {
// Filter out services which do not permit new allocations. // Filter out services which do not permit new allocations.

1
src/applications/repository/storage/PhabricatorRepository.php
View File

@@ -2038,6 +2038,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
->setViewer(PhabricatorUser::getOmnipotentUser()) ->setViewer(PhabricatorUser::getOmnipotentUser())
->withPHIDs(array($service_phid)) ->withPHIDs(array($service_phid))
->needBindings(true) ->needBindings(true)
->needProperties(true)
->executeOne(); ->executeOne();
if (!$service) { if (!$service) {
throw new Exception( throw new Exception(