archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix differential.createrevision conduit call

Browse Source 
Summary:
This introduces some boundary checking for
PhabricatorOwnersOwner::loadAffiliatedUserPHIDs() if it gets passed an empty
array, which happened when I ran arc diff and it called
differential.createrevision.

Test Plan: ran arc diff

Reviewers: epriestley, meitros, jungejason

CC: aran

Differential Revision: https://secure.phabricator.com/D2112
This commit is contained in:
Nick Harper
2012-04-05 15:19:58 -07:00
parent ff2b58dab7
commit efb49a6a09
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/applications/owners/storage/owner/PhabricatorOwnersOwner.php
View File

@@ -44,6 +44,9 @@ final class PhabricatorOwnersOwner extends PhabricatorOwnersDAO {
// Loads all user phids affiliated with a set of packages. This includes both // Loads all user phids affiliated with a set of packages. This includes both
// user owners and all members of any project owners // user owners and all members of any project owners
public static function loadAffiliatedUserPHIDs(array $package_ids) { public static function loadAffiliatedUserPHIDs(array $package_ids) {
if (!$package_ids) {
return array();
}
$owners = id(new PhabricatorOwnersOwner())->loadAllWhere( $owners = id(new PhabricatorOwnersOwner())->loadAllWhere(
'packageID IN (%Ls)', 'packageID IN (%Ls)',
$package_ids); $package_ids);