archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Point Maniphest reports at new transaction table

Browse Source 
Summary:
Ref T2217. Drive reports out of the new table. Nothing too magical going on here.

Also fixes a bug with one of the links from reports.

Test Plan: Viewed reports.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7081
This commit is contained in:
epriestley
2013-09-23 14:31:58 -07:00
parent 69523d30cc
commit efc7e7cd7e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/applications/maniphest/controller/ManiphestReportController.php
View File

@@ -79,14 +79,14 @@ final class ManiphestReportController extends ManiphestController {
$handle = $handles[$project_phid]; $handle = $handles[$project_phid];
} }
$table = new ManiphestTransaction(); $table = new ManiphestTransactionPro();
$conn = $table->establishConnection('r'); $conn = $table->establishConnection('r');
$joins = ''; $joins = '';
if ($project_phid) { if ($project_phid) {
$joins = qsprintf( $joins = qsprintf(
$conn, $conn,
'JOIN %T t ON x.taskID = t.id 'JOIN %T t ON x.objectPHID = t.phid
JOIN %T p ON p.taskPHID = t.phid AND p.projectPHID = %s', JOIN %T p ON p.taskPHID = t.phid AND p.projectPHID = %s',
id(new ManiphestTask())->getTableName(), id(new ManiphestTask())->getTableName(),
id(new ManiphestTaskProject())->getTableName(), id(new ManiphestTaskProject())->getTableName(),
@@ -522,7 +522,7 @@ final class ManiphestReportController extends ManiphestController {
$row[] = phutil_tag( $row[] = phutil_tag(
'a', 'a',
array( array(
'href' => '/maniphest/view/custom/?s=oc&tasks='.$task_ids, 'href' => '/maniphest/?ids='.$task_ids,
'target' => '_blank', 'target' => '_blank',
), ),
number_format(count($closed))); number_format(count($closed)));
@@ -652,12 +652,12 @@ final class ManiphestReportController extends ManiphestController {
list($ignored, $window_epoch) = $this->getWindow(); list($ignored, $window_epoch) = $this->getWindow();
$table = new ManiphestTask(); $table = new ManiphestTask();
$xtable = new ManiphestTransaction(); $xtable = new ManiphestTransactionPro();
$conn_r = $table->establishConnection('r'); $conn_r = $table->establishConnection('r');
$tasks = queryfx_all( $tasks = queryfx_all(
$conn_r, $conn_r,
'SELECT t.* FROM %T t JOIN %T x ON x.taskID = t.id 'SELECT t.* FROM %T t JOIN %T x ON x.objectPHID = t.phid
WHERE t.status != 0 WHERE t.status != 0
AND x.oldValue IN (null, %s, %s) AND x.oldValue IN (null, %s, %s)
AND x.newValue NOT IN (%s, %s) AND x.newValue NOT IN (%s, %s)