Remove flavor text for action buttons

Summary: A small but appreciable number of users find flavor on buttons confusing. Remove this flavor. This retains flavor in headers, error messages, etc., which doesn't cause confusion.

Test Plan: Looked at a revision, task, paste, macro, etc.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8812
This commit is contained in:
epriestley
2014-04-18 17:51:46 -07:00
parent ba956711a5
commit f1245f4f34
15 changed files with 27 additions and 81 deletions

View File

@@ -103,8 +103,6 @@ class AphrontDefaultApplicationConfiguration
return $response;
}
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
$user = $request->getUser();
if (!$user) {
// If we hit an exception very early, we won't have a user.
@@ -175,9 +173,9 @@ class AphrontDefaultApplicationConfiguration
->appendChild($content);
if ($this->getRequest()->isAjax()) {
$dialog->addCancelButton('/', 'Close');
$dialog->addCancelButton('/', pht('Close'));
} else {
$dialog->addCancelButton('/', $is_serious ? 'OK' : 'Away With Thee');
$dialog->addCancelButton('/', pht('OK'));
}
$response = new AphrontDialogResponse();