archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes

Browse Source 
Summary:
Depends on D20410. Ref T13272. Dashboards/Panels currently use older "ngram" indexing, which is a less-powerful precursor to Ferret. Throw away the ngram index and provide a Ferret index instead. Also:

  - Remove the NUX state, which links to the wrong place now and doesn't seem terribly important.
  - Add project tags to the search result list.
  - Make the "No Tags" tag a little less conspicious.

Test Plan:
  - Indexed dashboards and panels.
  - Searched for dashboards and panels via SearchEngine using Ferret "query" field.
  - Searched for panels via "Add Existing Panel" datasource typeahead.
  - Searched for dashboards via "Add Menu Item > Dashboard" on a ProfileMenu via typeahead.
  - Viewed dashboard NUX state (no special state, but no more bad link to "/create/").
  - Viewed dashboard list, saw project tags.
  - Viewed dashboards with no project tags ("No Tags" is now displayed but less visible).

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20411
This commit is contained in:
epriestley
2019-04-12 12:42:02 -07:00
parent 80b7274e0b
commit f13709b13b
29 changed files with 232 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webroot/rsrc/css/phui/phui-tag-view.css
View File

@@ -441,6 +441,12 @@ a.phui-tag-view:hover.phui-tag-disabled .phui-tag-core {
border-color: {$sh-disabledborder};
}
.phui-tag-placeholder .phui-tag-core {
border-color: transparent;
background-color: {$sh-disabledbackground};
opacity: 0.5;
}
/* - Outline Tags --------------------------------------------------------------
Basic Tag with a bold border and white background