PHUIList, PHUIDocument updates
Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
This commit is contained in:
@@ -55,7 +55,7 @@ final class PhabricatorPeopleProfileController
|
||||
$profile = $user->loadUserProfile();
|
||||
$username = phutil_escape_uri($user->getUserName());
|
||||
|
||||
$menu = new PhabricatorMenuView();
|
||||
$menu = new PHUIListView();
|
||||
foreach ($this->getMainFilters($username) as $filter) {
|
||||
$menu->newLink($filter['name'], $filter['href'], $filter['key']);
|
||||
}
|
||||
@@ -91,11 +91,11 @@ final class PhabricatorPeopleProfileController
|
||||
$added_label = true;
|
||||
}
|
||||
$menu->addMenuItem(
|
||||
id(new PhabricatorMenuItemView())
|
||||
id(new PHUIListItemView())
|
||||
->setIsExternal(true)
|
||||
->setName($name)
|
||||
->setHref($href)
|
||||
->setType(PhabricatorMenuItemView::TYPE_LINK));
|
||||
->setType(PHUIListItemView::TYPE_LINK));
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user