archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix an out-of-order issue in the new update-during-publish behavior

Browse Source 
Summary:
Ref T13552. The Herald field "Accepted Differential revision" (and similar fields) depend on the task/revision update steps running before Herald executes.

Herald currently executes first, so it never sees associated revisions. Swap this order.

Test Plan: Published a commit, got a clean parse/import. Will test with production rules ("Cowboy Commits").

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21468
This commit is contained in:
epriestley
2020-09-17 13:34:50 -07:00
parent a754c694de
commit f21a00a315
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php
View File

@@ -67,10 +67,17 @@ final class PhabricatorRepositoryCommitPublishWorker
return; return;
} }
$this->applyTransactions($viewer, $repository, $commit); // NOTE: Close revisions and tasks before applying transactions, because
// we want a side effect of closure (the commit being associated with
// a revision) to occur before a side effect of transactions (Herald
// executing). The close methods queue tasks for the actual updates to
// commits/revisions, so those won't occur until after the commit gets
// transactions.
$this->closeRevisions($viewer, $commit); $this->closeRevisions($viewer, $commit);
$this->closeTasks($viewer, $commit); $this->closeTasks($viewer, $commit);
$this->applyTransactions($viewer, $repository, $commit);
} }
private function applyTransactions( private function applyTransactions(