archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Align first nav item in settings

Browse Source 
Summary: This removes the redundant "Account" label and item, and just keeps the page better aligned.

Test Plan: Review personal settings

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18489
This commit is contained in:
Chad Little
2017-08-29 09:36:33 -07:00
parent 81f42b8343
commit f3f671aa90
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/applications/settings/controller/PhabricatorSettingsMainController.php
View File

@@ -205,7 +205,10 @@ final class PhabricatorSettingsMainController
if ($panel->getPanelGroupKey() != $group_key) { if ($panel->getPanelGroupKey() != $group_key) {
$group_key = $panel->getPanelGroupKey(); $group_key = $panel->getPanelGroupKey();
$group = $panel->getPanelGroup(); $group = $panel->getPanelGroup();
$nav->addLabel($group->getPanelGroupName()); $panel_name = $group->getPanelGroupName();
if ($panel_name) {
$nav->addLabel($panel_name);
}
} }
$nav->addFilter($panel->getPanelKey(), $panel->getPanelName()); $nav->addFilter($panel->getPanelKey(), $panel->getPanelName());

2
src/applications/settings/panelgroup/PhabricatorSettingsAccountPanelGroup.php
View File

@@ -6,7 +6,7 @@ final class PhabricatorSettingsAccountPanelGroup
const PANELGROUPKEY = 'account'; const PANELGROUPKEY = 'account';
public function getPanelGroupName() { public function getPanelGroupName() {
return pht('Account'); return null;
} }
protected function getPanelGroupOrder() { protected function getPanelGroupOrder() {