Add setHeader to PHUITwoColumnView for consistent page layouts

Summary: Working towards making PHUITwoColumnView into a page layout engine. Adds header support.

Test Plan: Use new header on Profile and Profiles. No visual changes, less duplicated code.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15292
This commit is contained in:
Chad Little
2016-02-17 13:05:24 -08:00
parent 12d8520059
commit f5e2f9587c
6 changed files with 30 additions and 33 deletions

View File

@@ -56,9 +56,11 @@ final class PhabricatorPeopleProfileViewController
$projects = $this->buildProjectsView($user);
$badges = $this->buildBadgesView($user);
require_celerity_resource('project-view-css');
$columns = id(new PHUITwoColumnView())
->addClass('project-view-badges')
$home = id(new PHUITwoColumnView())
->setHeader($header)
->addClass('project-view-home')
->setMainColumn(
array(
$properties,
@@ -76,17 +78,6 @@ final class PhabricatorPeopleProfileViewController
$crumbs = $this->buildApplicationCrumbs();
$crumbs->setBorder(true);
require_celerity_resource('project-view-css');
$home = phutil_tag(
'div',
array(
'class' => 'project-view-home',
),
array(
$header,
$columns,
));
return $this->newPage()
->setTitle($user->getUsername())
->setNavigation($nav)
@@ -217,6 +208,7 @@ final class PhabricatorPeopleProfileViewController
$box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Badges'))
->addClass('project-view-badges')
->appendChild($flex)
->setBackground(PHUIObjectBoxView::GREY);