render_tag -> tag: phabricator_render_form -> phabricator_form

Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use).

Test Plan: Poked around a bit.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4726

src/applications/differential/controller/DifferentialDiffViewController.php

@@ -113,9 +113,10 @@ final class DifferentialDiffViewController extends DifferentialController {
       }
     }
 
-    $action_panel = new AphrontHeadsupView();
-    $action_panel->setProperties($dict);
-    $action_panel->setHeader(pht('Diff Properties'));
+    $property_view = new PhabricatorPropertyListView();
+    foreach ($dict as $key => $value) {
+      $property_view->addProperty($key, $value);
+    }
 
     $changesets = $diff->loadChangesets();
     $changesets = msort($changesets, 'getSortKey');
@@ -144,7 +145,7 @@ final class DifferentialDiffViewController extends DifferentialController {
         ->appendChild(
           array(
             $top_panel->render(),
-            $action_panel->render(),
+            $property_view,
             $table_of_contents->render(),
             $details->render(),
           )),