archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

In "Move Tasks to Column...", show only visible columns

Browse Source 
Summary:
See PHI94. I considered this initially but wasn't sure about it. However, PHI94 brings up the good point that we already use a similar rule in Maniphest.

For consistency, only show visible columns here too.

Test Plan: Used "Move tasks to column..." on a board with visible and hidden columns, only saw visbile columns offered in the dropdown.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18668
This commit is contained in:
epriestley
2017-10-02 11:36:50 -07:00
parent cd14194a32
commit f9110b87ab
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
View File

@@ -313,6 +313,12 @@ final class PhabricatorProjectBoardViewController
$columns = $move_engine->getColumns($move_project->getPHID()); $columns = $move_engine->getColumns($move_project->getPHID());
$columns = mpull($columns, null, 'getPHID'); $columns = mpull($columns, null, 'getPHID');
foreach ($columns as $key => $column) {
if ($column->isHidden()) {
unset($columns[$key]);
}
}
$move_column_phid = $request->getStr('moveColumnPHID'); $move_column_phid = $request->getStr('moveColumnPHID');
if (!$move_column_phid) { if (!$move_column_phid) {
if ($request->getBool('hasColumn')) { if ($request->getBool('hasColumn')) {