Make "Assign / Claim" stacked action work properly in Maniphest

Summary:
Ref T9132. This is kind of a mess because the tokenizer rewrite left rendering tokenizers in Javascript a little rough. This causes bugs like icons not showing up on tokens in the "Policy" dialog, which there's a task for somewhere I think.

I think I've fixed it enough that the beahavior is now correct (i.e., icons show up properly), but some of the code is a bit iffy. I'll eventually clean this up properly, but it's fairly well contained for now.

Test Plan:
  - Reassigned a task.
  - Put a task up for grabs.
  - No reassign on closed tasks.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14669
This commit is contained in:
epriestley
2015-12-04 09:30:53 -08:00
parent 92ea07e787
commit f9e84d1a88
13 changed files with 249 additions and 103 deletions

View File

@@ -118,16 +118,21 @@ JX.install('PHUIXFormControl', {
spec.config);
build.tokenizer.start();
function set_value(map) {
for (var k in map) {
var v = JX.Prefab.transformDatasourceResults(map[k]);
build.tokenizer.addToken(k, v);
}
}
set_value(spec.value || {});
return {
node: build.node,
get: function() {
return JX.keys(build.tokenizer.getTokens());
},
set: function(map) {
for (var k in map) {
build.tokenizer.addToken(k, map[k]);
}
}
set: set_value
};
},