archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix Legalpad "Sign" box

Browse Source 
Summary: Missed converting this page, scenario. The box was poorly formatted.

Test Plan: Create a new document that needs signed, verify box is correctly spaced and colored.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15591
This commit is contained in:
Chad Little
2016-04-02 19:51:53 -07:00
parent e66bf17505
commit fa6151778f
3 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
resources/celerity/map.php
View File

@@ -128,7 +128,7 @@ return array(
'rsrc/css/phui/phui-chart.css' => '6bf6f78e', 'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
'rsrc/css/phui/phui-crumbs-view.css' => '79d536e5', 'rsrc/css/phui/phui-crumbs-view.css' => '79d536e5',
'rsrc/css/phui/phui-curtain-view.css' => '7148ae25', 'rsrc/css/phui/phui-curtain-view.css' => '7148ae25',
'rsrc/css/phui/phui-document-pro.css' => '92d5b648', 'rsrc/css/phui/phui-document-pro.css' => '73e45fd2',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
'rsrc/css/phui/phui-document.css' => '9c71d2bf', 'rsrc/css/phui/phui-document.css' => '9c71d2bf',
'rsrc/css/phui/phui-feed-story.css' => '04aec08f', 'rsrc/css/phui/phui-feed-story.css' => '04aec08f',
@@ -816,7 +816,7 @@ return array(
'phui-curtain-view-css' => '7148ae25', 'phui-curtain-view-css' => '7148ae25',
'phui-document-summary-view-css' => '9ca48bdf', 'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => '9c71d2bf', 'phui-document-view-css' => '9c71d2bf',
'phui-document-view-pro-css' => '92d5b648', 'phui-document-view-pro-css' => '73e45fd2',
'phui-feed-story-css' => '04aec08f', 'phui-feed-story-css' => '04aec08f',
'phui-font-icon-base-css' => '6449bce8', 'phui-font-icon-base-css' => '6449bce8',
'phui-fontkit-css' => '9cda225e', 'phui-fontkit-css' => '9cda225e',

17
src/applications/legalpad/controller/LegalpadDocumentSignController.php
View File

@@ -301,12 +301,15 @@ final class LegalpadDocumentSignController extends LegalpadController {
case LegalpadDocument::SIGNATURE_TYPE_INDIVIDUAL: case LegalpadDocument::SIGNATURE_TYPE_INDIVIDUAL:
case LegalpadDocument::SIGNATURE_TYPE_CORPORATION: case LegalpadDocument::SIGNATURE_TYPE_CORPORATION:
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->addClass('document-sign-box')
->setHeaderText(pht('Agree and Sign Document')) ->setHeaderText(pht('Agree and Sign Document'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setForm($signature_form); ->setForm($signature_form);
if ($error_view) { if ($error_view) {
$box->setInfoView($error_view); $box->setInfoView($error_view);
} }
$signature_box = phutil_tag_div('phui-document-view-pro-box', $box); $signature_box = phutil_tag_div(
'phui-document-view-pro-box plt', $box);
break; break;
} }
@@ -317,15 +320,13 @@ final class LegalpadDocumentSignController extends LegalpadController {
$crumbs->setBorder(true); $crumbs->setBorder(true);
$crumbs->addTextCrumb($document->getMonogram()); $crumbs->addTextCrumb($document->getMonogram());
return $this->buildApplicationPage( return $this->newPage()
array( ->setTitle($title)
$crumbs, ->setCrumbs($crumbs)
->setPageObjectPHIDs(array($document->getPHID()))
->appendChild(array(
$content, $content,
$signature_box, $signature_box,
),
array(
'title' => $title,
'pageObjects' => array($document->getPHID()),
)); ));
} }

4
webroot/rsrc/css/phui/phui-document-pro.css
View File

@@ -190,10 +190,6 @@ a.button.phui-document-toc {
margin: 0; margin: 0;
} }
.phui-document-view-pro-box .phui-object-box .phui-form-view {
padding-bottom: 0;
}
.phui-document-view-pro-box .phui-object-box .remarkup-assist-textarea { .phui-document-view-pro-box .phui-object-box .remarkup-assist-textarea {
height: 9em; height: 9em;
} }