archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Allow "Wait for Message" to be unset on build plans

Browse Source 
Summary: Fixes T11910. I spent a couple of minutes looking for the root cause without much luck, but this will all be obsoleted by an eventual upgrade to `EditEngine` anyway.

Test Plan: Set and unset "Wait for Message", which now worked.

Reviewers: chad, avivey

Reviewed By: avivey

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T11910

Differential Revision: https://secure.phabricator.com/D16919
This commit is contained in:
epriestley
2016-11-22 13:46:30 -08:00
parent add20783ab
commit faf42cbe8f
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php
View File

@@ -43,7 +43,7 @@ final class HarbormasterBuildStepCoreCustomField
'the result for this step. After the result is recorded, the build '. 'the result for this step. After the result is recorded, the build '.
'plan will resume.'), 'plan will resume.'),
'options' => array( 'options' => array(
'' => pht('Continue Build Normally'), 'continue' => pht('Continue Build Normally'),
'wait' => pht('Wait For Message'), 'wait' => pht('Wait For Message'),
), ),
); );

3
src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
View File

@@ -237,7 +237,8 @@ abstract class HarbormasterBuildStepImplementation extends Phobject {
return false; return false;
} }
return (bool)$target->getDetail('builtin.wait-for-message'); $wait = $target->getDetail('builtin.wait-for-message');
return ($wait == 'wait');
} }
protected function shouldAbort( protected function shouldAbort(