Update Form Layouts

Summary:
This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere.

TODO: will take another pass as consolidating these colors and new gradients in another diff.

Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6806
This commit is contained in:
Chad Little
2013-08-26 11:53:11 -07:00
parent 320498d3d0
commit fe2a96e37f
117 changed files with 633 additions and 589 deletions

View File

@@ -91,7 +91,6 @@ final class PhabricatorProjectMembersEditController
$form = new AphrontFormView();
$form
->setUser($user)
->setFlexible(true)
->appendChild(
id(new AphrontFormTokenizerControl())
->setName('phids')
@@ -101,17 +100,19 @@ final class PhabricatorProjectMembersEditController
id(new AphrontFormSubmitControl())
->addCancelButton('/project/view/'.$project->getID().'/')
->setValue(pht('Add Members')));
$faux_form = id(new AphrontFormLayoutView())
$faux_form = id(new AphrontFormView())
->setUser($user)
->appendChild(
id(new AphrontFormInsetView())
->setTitle(pht('Current Members (%d)', count($handles)))
->appendChild($list));
$box = new PHUIBoxView();
$box->appendChild($faux_form);
$box->setShadow(true);
$box->addPadding(PHUI::PADDING_LARGE);
$box->addMargin(PHUI::MARGIN_LARGE);
$box = id(new PHUIFormBoxView())
->setHeaderText(pht('Current Members (%d)', count($handles)))
->setForm($faux_form);
$form_box = id(new PHUIFormBoxView())
->setHeaderText($title)
->setForm($form);
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
$crumbs->addCrumb(
@@ -126,7 +127,7 @@ final class PhabricatorProjectMembersEditController
return $this->buildApplicationPage(
array(
$crumbs,
$form,
$form_box,
$box,
),
array(