cbb5a297d5
Summary: Ref T1460. See D12126. This is essentially the same change, but for Diffusion. This is a bit copy/pastey. I'm going to make an effort to lift inline handling into the core before pushing this in, so hopefully that will clean things up a bit. Test Plan: Submitted stuff in Diffusion and got checkmarks to publish. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12128
117 lines
2.9 KiB
PHP
117 lines
2.9 KiB
PHP
<?php
|
|
|
|
final class DiffusionInlineCommentController
|
|
extends PhabricatorInlineCommentController {
|
|
|
|
private $commitPHID;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->commitPHID = $data['phid'];
|
|
}
|
|
|
|
protected function createComment() {
|
|
|
|
// Verify commit and path correspond to actual objects.
|
|
$commit_phid = $this->commitPHID;
|
|
$path_id = $this->getChangesetID();
|
|
|
|
$commit = id(new PhabricatorRepositoryCommit())->loadOneWhere(
|
|
'phid = %s',
|
|
$commit_phid);
|
|
if (!$commit) {
|
|
throw new Exception('Invalid commit ID!');
|
|
}
|
|
|
|
// TODO: Write a real PathQuery object?
|
|
|
|
$path = queryfx_one(
|
|
id(new PhabricatorRepository())->establishConnection('r'),
|
|
'SELECT path FROM %T WHERE id = %d',
|
|
PhabricatorRepository::TABLE_PATH,
|
|
$path_id);
|
|
|
|
if (!$path) {
|
|
throw new Exception('Invalid path ID!');
|
|
}
|
|
|
|
return id(new PhabricatorAuditInlineComment())
|
|
->setCommitPHID($commit_phid)
|
|
->setPathID($path_id);
|
|
}
|
|
|
|
protected function loadComment($id) {
|
|
return PhabricatorAuditInlineComment::loadID($id);
|
|
}
|
|
|
|
protected function loadCommentByPHID($phid) {
|
|
return PhabricatorAuditInlineComment::loadPHID($phid);
|
|
}
|
|
|
|
protected function loadCommentForEdit($id) {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$inline = $this->loadComment($id);
|
|
if (!$this->canEditInlineComment($user, $inline)) {
|
|
throw new Exception('That comment is not editable!');
|
|
}
|
|
return $inline;
|
|
}
|
|
|
|
protected function loadCommentForDone($id) {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$inline = $this->loadComment($id);
|
|
if (!$inline) {
|
|
throw new Exception(pht('Failed to load comment "%d".', $id));
|
|
}
|
|
|
|
$commit = id(new DiffusionCommitQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($inline->getCommitPHID()))
|
|
->executeOne();
|
|
if (!$commit) {
|
|
throw new Exception(pht('Failed to load commit.'));
|
|
}
|
|
|
|
if ((!$commit->getAuthorPHID()) ||
|
|
($commit->getAuthorPHID() != $viewer->getPHID())) {
|
|
throw new Exception(pht('You can not mark this comment as complete.'));
|
|
}
|
|
|
|
return $inline;
|
|
}
|
|
|
|
private function canEditInlineComment(
|
|
PhabricatorUser $user,
|
|
PhabricatorAuditInlineComment $inline) {
|
|
|
|
// Only the author may edit a comment.
|
|
if ($inline->getAuthorPHID() != $user->getPHID()) {
|
|
return false;
|
|
}
|
|
|
|
// Saved comments may not be edited.
|
|
if ($inline->getAuditCommentID()) {
|
|
return false;
|
|
}
|
|
|
|
// Inline must be attached to the active revision.
|
|
if ($inline->getCommitPHID() != $this->commitPHID) {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
protected function deleteComment(PhabricatorInlineCommentInterface $inline) {
|
|
return $inline->delete();
|
|
}
|
|
|
|
protected function saveComment(PhabricatorInlineCommentInterface $inline) {
|
|
return $inline->save();
|
|
}
|
|
|
|
}
|