Summary: Ref T13362. Some applications moved to fixed-width a while ago but I was generally unsatisfied with where they ended up and have been pushing them back to full-width. Push Config back to full-width. Some of the subpages end up a little weird, but this provides more space to work with to make some improvements, like makign `maniphest.statuses` more legible in the UI> Test Plan: Grepped for `setFixed(`, updated each page in `/config/`. Browsed each controller, saw workable full-width UIs. Maniphest Tasks: T13362 Differential Revision: https://secure.phabricator.com/D20925
76 lines
1.9 KiB
PHP
76 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class PhabricatorConfigIssueViewController
|
|
extends PhabricatorConfigController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $request->getViewer();
|
|
$issue_key = $request->getURIData('key');
|
|
|
|
$engine = new PhabricatorSetupEngine();
|
|
$response = $engine->execute();
|
|
if ($response) {
|
|
return $response;
|
|
}
|
|
$issues = $engine->getIssues();
|
|
|
|
$nav = $this->buildSideNavView();
|
|
$nav->selectFilter('issue/');
|
|
|
|
if (empty($issues[$issue_key])) {
|
|
$content = id(new PHUIInfoView())
|
|
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
|
|
->setTitle(pht('Issue Resolved'))
|
|
->appendChild(pht('This setup issue has been resolved. '))
|
|
->appendChild(
|
|
phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $this->getApplicationURI('issue/'),
|
|
),
|
|
pht('Return to Open Issue List')));
|
|
$title = pht('Resolved Issue');
|
|
} else {
|
|
$issue = $issues[$issue_key];
|
|
$content = $this->renderIssue($issue);
|
|
$title = $issue->getShortName();
|
|
}
|
|
|
|
$header = $this->buildHeaderView($title);
|
|
|
|
$crumbs = $this
|
|
->buildApplicationCrumbs()
|
|
->setBorder(true)
|
|
->addTextCrumb(pht('Setup Issues'), $this->getApplicationURI('issue/'))
|
|
->addTextCrumb($title, $request->getRequestURI())
|
|
->setBorder(true);
|
|
|
|
$content = id(new PHUITwoColumnView())
|
|
->setHeader($header)
|
|
->setFooter($content);
|
|
|
|
return $this->newPage()
|
|
->setTitle($title)
|
|
->setCrumbs($crumbs)
|
|
->setNavigation($nav)
|
|
->appendChild($content);
|
|
}
|
|
|
|
private function renderIssue(PhabricatorSetupIssue $issue) {
|
|
require_celerity_resource('setup-issue-css');
|
|
|
|
$view = new PhabricatorSetupIssueView();
|
|
$view->setIssue($issue);
|
|
|
|
$container = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'setup-issue-background',
|
|
),
|
|
$view->render());
|
|
|
|
return $container;
|
|
}
|
|
|
|
}
|