1fc60a9a6e
Summary:
Ref T1806. Ref T7173. Depends on D14047.
Currently, all exception handling is in this big messy clump in `AphrontDefaultApplicationConfiguration`.
Split it out into modular classes. This will let a future change add new classes in the Phacility cluster which intercept particular exceptions we care about and replaces the default, generic responses with more useful, tailored responses.
Test Plan:
{F777391}
- Hit a Conduit error (made a method throw).
- Hit an Ajax error (made comment preview throw).
- Hit a high security error (tried to edit TOTP).
- Hit a rate limiting error (added a bunch of email addresses).
- Hit a policy error (tried to look at something with no permission).
- Hit an arbitrary exception (made a randomc ontroller throw).
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T1806, T7173
Differential Revision: https://secure.phabricator.com/D14049
27 lines
548 B
PHP
27 lines
548 B
PHP
<?php
|
|
|
|
abstract class PhabricatorRequestExceptionHandler
|
|
extends AphrontRequestExceptionHandler {
|
|
|
|
protected function isPhabricatorSite(AphrontRequest $request) {
|
|
$site = $request->getSite();
|
|
if (!$site) {
|
|
return false;
|
|
}
|
|
|
|
return ($site instanceof PhabricatorSite);
|
|
}
|
|
|
|
protected function getViewer(AphrontRequest $request) {
|
|
$viewer = $request->getUser();
|
|
|
|
if ($viewer) {
|
|
return $viewer;
|
|
}
|
|
|
|
// If we hit an exception very early, we won't have a user yet.
|
|
return new PhabricatorUser();
|
|
}
|
|
|
|
}
|