Summary:
Fixes T9126. In particular:
- Add "Browse" links to all history views.
- Use icons to show "Browse" and "History" links, instead of text.
- Use FontAwesome.
- Generally standardize handling of these elements.
This might need a little design attention, but I think it's an improvement overall.
Test Plan:
- Viewed repository history.
- Viewed branch history.
- Viewed file history.
- Viewed table of contents on a commit.
- Viewed merged changes on a merge commit.
- Viewed a directory containing an external.
- Viewed a deleted file.
{F788419}
{F788420}
{F788421}
{F788422}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9126
Differential Revision: https://secure.phabricator.com/D14096
156 lines
3.8 KiB
PHP
156 lines
3.8 KiB
PHP
<?php
|
|
|
|
final class DiffusionBrowseTableView extends DiffusionView {
|
|
|
|
private $paths;
|
|
private $handles = array();
|
|
|
|
public function setPaths(array $paths) {
|
|
assert_instances_of($paths, 'DiffusionRepositoryPath');
|
|
$this->paths = $paths;
|
|
return $this;
|
|
}
|
|
|
|
public function setHandles(array $handles) {
|
|
assert_instances_of($handles, 'PhabricatorObjectHandle');
|
|
$this->handles = $handles;
|
|
return $this;
|
|
}
|
|
|
|
public function render() {
|
|
$request = $this->getDiffusionRequest();
|
|
$repository = $request->getRepository();
|
|
|
|
$base_path = trim($request->getPath(), '/');
|
|
if ($base_path) {
|
|
$base_path = $base_path.'/';
|
|
}
|
|
|
|
$need_pull = array();
|
|
$rows = array();
|
|
$show_edit = false;
|
|
foreach ($this->paths as $path) {
|
|
|
|
$dir_slash = null;
|
|
$file_type = $path->getFileType();
|
|
if ($file_type == DifferentialChangeType::FILE_DIRECTORY) {
|
|
$browse_text = $path->getPath().'/';
|
|
$dir_slash = '/';
|
|
|
|
$browse_link = phutil_tag('strong', array(), $this->linkBrowse(
|
|
$base_path.$path->getPath().$dir_slash,
|
|
array(
|
|
'type' => $file_type,
|
|
'name' => $browse_text,
|
|
)));
|
|
} else if ($file_type == DifferentialChangeType::FILE_SUBMODULE) {
|
|
$browse_text = $path->getPath().'/';
|
|
$browse_link = phutil_tag('strong', array(), $this->linkBrowse(
|
|
null,
|
|
array(
|
|
'type' => $file_type,
|
|
'name' => $browse_text,
|
|
'hash' => $path->getHash(),
|
|
'external' => $path->getExternalURI(),
|
|
)));
|
|
} else {
|
|
$browse_text = $path->getPath();
|
|
$browse_link = $this->linkBrowse(
|
|
$base_path.$path->getPath(),
|
|
array(
|
|
'type' => $file_type,
|
|
'name' => $browse_text,
|
|
));
|
|
}
|
|
|
|
$dict = array(
|
|
'lint' => celerity_generate_unique_node_id(),
|
|
'commit' => celerity_generate_unique_node_id(),
|
|
'date' => celerity_generate_unique_node_id(),
|
|
'time' => celerity_generate_unique_node_id(),
|
|
'author' => celerity_generate_unique_node_id(),
|
|
'details' => celerity_generate_unique_node_id(),
|
|
);
|
|
|
|
$need_pull[$base_path.$path->getPath().$dir_slash] = $dict;
|
|
foreach ($dict as $k => $uniq) {
|
|
$dict[$k] = phutil_tag('span', array('id' => $uniq), '');
|
|
}
|
|
|
|
$rows[] = array(
|
|
$browse_link,
|
|
idx($dict, 'lint'),
|
|
$dict['commit'],
|
|
$dict['author'],
|
|
$dict['details'],
|
|
$dict['date'],
|
|
$dict['time'],
|
|
);
|
|
}
|
|
|
|
if ($need_pull) {
|
|
Javelin::initBehavior(
|
|
'diffusion-pull-lastmodified',
|
|
array(
|
|
'uri' => (string)$request->generateURI(
|
|
array(
|
|
'action' => 'lastmodified',
|
|
'stable' => true,
|
|
)),
|
|
'map' => $need_pull,
|
|
));
|
|
}
|
|
|
|
$branch = $this->getDiffusionRequest()->loadBranch();
|
|
$show_lint = ($branch && $branch->getLintCommit());
|
|
$lint = $request->getLint();
|
|
|
|
$view = new AphrontTableView($rows);
|
|
$view->setHeaders(
|
|
array(
|
|
pht('Path'),
|
|
($lint ? $lint : pht('Lint')),
|
|
pht('Modified'),
|
|
pht('Author/Committer'),
|
|
pht('Details'),
|
|
pht('Date'),
|
|
pht('Time'),
|
|
));
|
|
$view->setColumnClasses(
|
|
array(
|
|
'',
|
|
'n',
|
|
'n',
|
|
'',
|
|
'wide',
|
|
'',
|
|
'right',
|
|
));
|
|
$view->setColumnVisibility(
|
|
array(
|
|
true,
|
|
$show_lint,
|
|
true,
|
|
true,
|
|
true,
|
|
true,
|
|
true,
|
|
));
|
|
|
|
$view->setDeviceVisibility(
|
|
array(
|
|
true,
|
|
false,
|
|
true,
|
|
false,
|
|
true,
|
|
false,
|
|
false,
|
|
));
|
|
|
|
|
|
return $view->render();
|
|
}
|
|
|
|
}
|