Summary: - For line numbers, use "user-select: none" to make them unselectable. This provides a stronger visual cue that copy/paste is enchanted. - In Paste, make it look sensible again after the blame-on-blame refactor in Diffusion. See also TODO to share this code formally. - In Diffusion, use the "phabricator-oncopy" behavior. NOTE: I left blame/commit columns selectable in Diffusion, since you might reasonably want to copy/paste them? NOTE: In Differential, the left side of the diff still highlights, even though it will be copied only if you select part of a line on the left and nothing else. But this seemed like a reasonable behavior, so I left it. Test Plan: - Looked at Paste. Saw a nice line number column. Selected text, got the expected selection. Copied text, got the expected copy. - Looked at Diffusion. Saw a nice line number column, still. Selected text, got expected selection. Copied text, got expected copy. - Looked at Differential. Highlighted stuff, got expected results. Copied stuff, got expected results. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1123 Differential Revision: https://secure.phabricator.com/D2242
207 lines
5.3 KiB
PHP
207 lines
5.3 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class PhabricatorPasteViewController extends PhabricatorPasteController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$paste = id(new PhabricatorPasteQuery())
|
|
->setViewer($user)
|
|
->withPasteIDs(array($this->id))
|
|
->executeOne();
|
|
|
|
if (!$paste) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$file = id(new PhabricatorFile())->loadOneWhere(
|
|
'phid = %s',
|
|
$paste->getFilePHID());
|
|
if (!$file) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$corpus = $this->buildCorpus($paste, $file);
|
|
$paste_panel = new AphrontPanelView();
|
|
|
|
if (strlen($paste->getTitle())) {
|
|
$paste_panel->setHeader(
|
|
'Viewing Paste '.$paste->getID().' - '.
|
|
phutil_escape_html($paste->getTitle()));
|
|
} else {
|
|
$paste_panel->setHeader('Viewing Paste '.$paste->getID());
|
|
}
|
|
|
|
$paste_panel->setWidth(AphrontPanelView::WIDTH_FULL);
|
|
$paste_panel->addButton(
|
|
phutil_render_tag(
|
|
'a',
|
|
array(
|
|
'href' => '/paste/?fork='.$paste->getID(),
|
|
'class' => 'green button',
|
|
),
|
|
'Fork This'));
|
|
|
|
$raw_uri = $file->getBestURI();
|
|
$paste_panel->addButton(
|
|
phutil_render_tag(
|
|
'a',
|
|
array(
|
|
'href' => $raw_uri,
|
|
'class' => 'button',
|
|
),
|
|
'View Raw Text'));
|
|
|
|
$paste_panel->appendChild($corpus);
|
|
|
|
$forks_panel = null;
|
|
$forks_of_this_paste = id(new PhabricatorPaste())->loadAllWhere(
|
|
'parentPHID = %s',
|
|
$paste->getPHID());
|
|
|
|
if ($forks_of_this_paste) {
|
|
$forks_panel = new AphrontPanelView();
|
|
$forks_panel->setHeader("Forks of this paste");
|
|
$forks = array();
|
|
foreach ($forks_of_this_paste as $fork) {
|
|
$forks[] = array(
|
|
$fork->getID(),
|
|
phutil_render_tag(
|
|
'a',
|
|
array(
|
|
'href' => '/P'.$fork->getID(),
|
|
),
|
|
phutil_escape_html($fork->getTitle())
|
|
)
|
|
);
|
|
}
|
|
$forks_table = new AphrontTableView($forks);
|
|
$forks_table->setHeaders(
|
|
array(
|
|
'Paste ID',
|
|
'Title',
|
|
)
|
|
);
|
|
$forks_table->setColumnClasses(
|
|
array(
|
|
null,
|
|
'wide pri',
|
|
)
|
|
);
|
|
$forks_panel->appendChild($forks_table);
|
|
}
|
|
|
|
return $this->buildStandardPageResponse(
|
|
array(
|
|
$paste_panel,
|
|
$forks_panel,
|
|
),
|
|
array(
|
|
'title' => 'Paste: '.nonempty($paste->getTitle(), 'P'.$paste->getID()),
|
|
'tab' => 'view',
|
|
));
|
|
}
|
|
|
|
private function buildCorpus($paste, $file) {
|
|
// Blantently copied from DiffusionBrowseFileController
|
|
|
|
require_celerity_resource('diffusion-source-css');
|
|
require_celerity_resource('syntax-highlighting-css');
|
|
|
|
$language = $paste->getLanguage();
|
|
$source = $file->loadFileData();
|
|
if (empty($language)) {
|
|
$source = PhabricatorSyntaxHighlighter::highlightWithFilename(
|
|
$paste->getTitle(),
|
|
$source);
|
|
} else {
|
|
$source = PhabricatorSyntaxHighlighter::highlightWithLanguage(
|
|
$language,
|
|
$source);
|
|
}
|
|
|
|
$text_list = explode("\n", $source);
|
|
|
|
Javelin::initBehavior('phabricator-oncopy', array());
|
|
$rows = $this->buildDisplayRows($text_list);
|
|
|
|
// TODO: Split the "one-up source listing" view into its own class and
|
|
// share it properly between Paste and Diffusion.
|
|
|
|
$corpus_table = phutil_render_tag(
|
|
'table',
|
|
array(
|
|
'class' => 'diffusion-source remarkup-code PhabricatorMonospaced',
|
|
),
|
|
implode("\n", $rows));
|
|
|
|
$corpus = phutil_render_tag(
|
|
'div',
|
|
array(
|
|
'style' => 'padding: 0pt 2em;',
|
|
),
|
|
$corpus_table);
|
|
|
|
return $corpus;
|
|
}
|
|
|
|
private function buildDisplayRows($text_list) {
|
|
$rows = array();
|
|
$n = 1;
|
|
|
|
foreach ($text_list as $k => $line) {
|
|
// Pardon the ugly for the time being.
|
|
// And eventually this will highlight a line that you click
|
|
// like diffusion does. Or maybe allow for line comments
|
|
// like differential. Either way it will be better than it is now.
|
|
$anchor = 'L'.$n;
|
|
$link = phutil_render_tag(
|
|
'a',
|
|
array(
|
|
'name' => $anchor,
|
|
'href' => '#'.$anchor,
|
|
),
|
|
$n);
|
|
$link = phutil_render_tag(
|
|
'th',
|
|
array(
|
|
'class' => 'diffusion-line-link',
|
|
),
|
|
$link);
|
|
$rows[] = '<tr id="'.$anchor.'">'.$link.
|
|
'<td style="white-space: pre-wrap;">'.
|
|
// NOTE: See the 'phabricator-oncopy' behavior.
|
|
"\xE2\x80\x8B".
|
|
$line.'</td></tr>';
|
|
++$n;
|
|
}
|
|
|
|
return $rows;
|
|
}
|
|
|
|
}
|