f46263903c
Summary: Pathway to D17685. This fixes an issue idenified in D17731: if any caller ever queried for more than one participant, some results could get thrown away by re-keying the results on thread PHID: two different participants can be members of the same thread! This also fixes an issue from D17683, where a `needParticipantCache()` callsite was overlooked. Test Plan: - Viewed Conpherence dropdown. - Sent messages, saw unread count / thread order still work properly. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17732
139 lines
3.8 KiB
PHP
139 lines
3.8 KiB
PHP
<?php
|
|
|
|
final class ConpherenceNotificationPanelController
|
|
extends ConpherenceController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$user = $request->getUser();
|
|
$conpherences = array();
|
|
require_celerity_resource('conpherence-notification-css');
|
|
|
|
$participant_data = id(new ConpherenceParticipantQuery())
|
|
->withParticipantPHIDs(array($user->getPHID()))
|
|
->setLimit(5)
|
|
->execute();
|
|
$participant_data = mpull($participant_data, null, 'getConpherencePHID');
|
|
|
|
if ($participant_data) {
|
|
$conpherences = id(new ConpherenceThreadQuery())
|
|
->setViewer($user)
|
|
->withPHIDs(array_keys($participant_data))
|
|
->needProfileImage(true)
|
|
->needTransactions(true)
|
|
->setTransactionLimit(100)
|
|
->execute();
|
|
}
|
|
|
|
if ($conpherences) {
|
|
// re-order the conpherences based on participation data
|
|
$conpherences = array_select_keys(
|
|
$conpherences, array_keys($participant_data));
|
|
$view = new AphrontNullView();
|
|
foreach ($conpherences as $conpherence) {
|
|
$p_data = $participant_data[$conpherence->getPHID()];
|
|
$d_data = $conpherence->getDisplayData($user);
|
|
$classes = array(
|
|
'phabricator-notification',
|
|
'conpherence-notification',
|
|
);
|
|
|
|
if (!$p_data->isUpToDate($conpherence)) {
|
|
$classes[] = 'phabricator-notification-unread';
|
|
}
|
|
$uri = $this->getApplicationURI($conpherence->getID().'/');
|
|
$title = $d_data['title'];
|
|
$subtitle = $d_data['subtitle'];
|
|
$unread_count = $d_data['unread_count'];
|
|
$epoch = $d_data['epoch'];
|
|
$image = $d_data['image'];
|
|
|
|
$msg_view = id(new ConpherenceMenuItemView())
|
|
->setUser($user)
|
|
->setTitle($title)
|
|
->setSubtitle($subtitle)
|
|
->setHref($uri)
|
|
->setEpoch($epoch)
|
|
->setImageURI($image)
|
|
->setUnreadCount($unread_count);
|
|
|
|
$view->appendChild(javelin_tag(
|
|
'div',
|
|
array(
|
|
'class' => implode(' ', $classes),
|
|
'sigil' => 'notification',
|
|
'meta' => array(
|
|
'href' => $uri,
|
|
),
|
|
),
|
|
$msg_view));
|
|
}
|
|
$content = $view->render();
|
|
} else {
|
|
$rooms_uri = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => '/conpherence/',
|
|
'class' => 'no-room-notification',
|
|
),
|
|
pht('You have joined no rooms.'));
|
|
|
|
$content = phutil_tag_div(
|
|
'phabricator-notification no-notifications', $rooms_uri);
|
|
}
|
|
|
|
$content = hsprintf(
|
|
'<div class="phabricator-notification-header grouped">%s%s</div>'.
|
|
'%s',
|
|
phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => '/conpherence/',
|
|
),
|
|
pht('Rooms')),
|
|
$this->renderPersistentOption(),
|
|
$content);
|
|
|
|
$unread = id(new ConpherenceParticipantCountQuery())
|
|
->withParticipantPHIDs(array($user->getPHID()))
|
|
->withUnread(true)
|
|
->execute();
|
|
$unread_count = idx($unread, $user->getPHID(), 0);
|
|
|
|
$json = array(
|
|
'content' => $content,
|
|
'number' => (int)$unread_count,
|
|
);
|
|
|
|
return id(new AphrontAjaxResponse())->setContent($json);
|
|
}
|
|
|
|
private function renderPersistentOption() {
|
|
$viewer = $this->getViewer();
|
|
$column_key = PhabricatorConpherenceColumnVisibleSetting::SETTINGKEY;
|
|
$show = (bool)$viewer->getUserSetting($column_key, false);
|
|
|
|
$view = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'persistent-option',
|
|
),
|
|
array(
|
|
javelin_tag(
|
|
'input',
|
|
array(
|
|
'type' => 'checkbox',
|
|
'checked' => ($show) ? 'checked' : null,
|
|
'value' => !$show,
|
|
'sigil' => 'conpherence-persist-column',
|
|
)),
|
|
phutil_tag(
|
|
'span',
|
|
array(),
|
|
pht('Persistent Chat')),
|
|
));
|
|
|
|
return $view;
|
|
}
|
|
|
|
}
|