74de153e59
Summary: Depends on D20272. Ref T13074. When a task requires MFA to edit, you currently get a fatal. Provide a cancel URI so the prompt works and the edit can go through. Test Plan: - Locked a task, dragged it on a workboard. - Before: fatal trying to build an MFA gate. - After: got MFA gated, answered prompt, action went through. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13074 Differential Revision: https://secure.phabricator.com/D20273
126 lines
3.4 KiB
PHP
126 lines
3.4 KiB
PHP
<?php
|
|
|
|
final class PhabricatorProjectMoveController
|
|
extends PhabricatorProjectController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $request->getViewer();
|
|
$id = $request->getURIData('id');
|
|
|
|
$request->validateCSRF();
|
|
|
|
$column_phid = $request->getStr('columnPHID');
|
|
$object_phid = $request->getStr('objectPHID');
|
|
$after_phid = $request->getStr('afterPHID');
|
|
$before_phid = $request->getStr('beforePHID');
|
|
|
|
$order = $request->getStr('order');
|
|
if (!strlen($order)) {
|
|
$order = PhabricatorProjectColumnNaturalOrder::ORDERKEY;
|
|
}
|
|
|
|
$ordering = PhabricatorProjectColumnOrder::getOrderByKey($order);
|
|
$ordering = id(clone $ordering)
|
|
->setViewer($viewer);
|
|
|
|
$edit_header = null;
|
|
$raw_header = $request->getStr('header');
|
|
if (strlen($raw_header)) {
|
|
$edit_header = phutil_json_decode($raw_header);
|
|
} else {
|
|
$edit_header = array();
|
|
}
|
|
|
|
$project = id(new PhabricatorProjectQuery())
|
|
->setViewer($viewer)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
))
|
|
->withIDs(array($id))
|
|
->executeOne();
|
|
if (!$project) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$cancel_uri = $this->getApplicationURI(
|
|
new PhutilURI(
|
|
urisprintf('board/%d/', $project->getID()),
|
|
array(
|
|
'order' => $order,
|
|
)));
|
|
|
|
$board_phid = $project->getPHID();
|
|
|
|
$object = id(new ManiphestTaskQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($object_phid))
|
|
->needProjectPHIDs(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
|
|
if (!$object) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$columns = id(new PhabricatorProjectColumnQuery())
|
|
->setViewer($viewer)
|
|
->withProjectPHIDs(array($project->getPHID()))
|
|
->execute();
|
|
|
|
$columns = mpull($columns, null, 'getPHID');
|
|
$column = idx($columns, $column_phid);
|
|
if (!$column) {
|
|
// User is trying to drop this object into a nonexistent column, just kick
|
|
// them out.
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$engine = id(new PhabricatorBoardLayoutEngine())
|
|
->setViewer($viewer)
|
|
->setBoardPHIDs(array($board_phid))
|
|
->setObjectPHIDs(array($object_phid))
|
|
->executeLayout();
|
|
|
|
$order_params = array();
|
|
if ($after_phid) {
|
|
$order_params['afterPHID'] = $after_phid;
|
|
} else if ($before_phid) {
|
|
$order_params['beforePHID'] = $before_phid;
|
|
}
|
|
|
|
$xactions = array();
|
|
$xactions[] = id(new ManiphestTransaction())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_COLUMNS)
|
|
->setNewValue(
|
|
array(
|
|
array(
|
|
'columnPHID' => $column->getPHID(),
|
|
) + $order_params,
|
|
));
|
|
|
|
$header_xactions = $ordering->getColumnTransactions(
|
|
$object,
|
|
$edit_header);
|
|
foreach ($header_xactions as $header_xaction) {
|
|
$xactions[] = $header_xaction;
|
|
}
|
|
|
|
$editor = id(new ManiphestTransactionEditor())
|
|
->setActor($viewer)
|
|
->setContinueOnMissingFields(true)
|
|
->setContinueOnNoEffect(true)
|
|
->setContentSourceFromRequest($request)
|
|
->setCancelURI($cancel_uri);
|
|
|
|
$editor->applyTransactions($object, $xactions);
|
|
|
|
return $this->newCardResponse($board_phid, $object_phid, $ordering);
|
|
}
|
|
|
|
}
|