Summary: Ref T5245. This is some of the associated cleanup there.
Test Plan:
foreach ManiphestTaskQuery site, I made the change (or not) and tested as follows:
=== Call sites where added needProjectPHIDs ===
- PhabricatorHomeMainController - loaded the home page
- ManiphestBatchEditController - batch edited some tasks (added a project)
- ManiphestConduitAPIMethod - tested implicitly when tested ManiphestUpdateConduitAPIMethod
- ManiphestInfoConduitAPIMethod - used the method via conduit console with input id : 1
- ManiphestQueryConduitAPIMethod - used the method via conduit console with input ids : [1, 2]
- ManiphestUpdateConduitAPIMethod - used the method via conduit with input id : 1 and comment : “asdasds"
- ManiphestReportController - viewed “By User” and “By Project”
- ManiphestSubpriorityController - changed the priority of a task via a drag on manphest home
- ManiphestTaskMailReceiver - updated Task 1 via bin/mail receive-test with a comment that is the README
- ManiphestTaskSearchEngine - loaded Manifest home page
- ManiphestTaskEditController - edited a task
- ManiphestTransactionEditor - closed a blocking task
- ManiphestTransactionSaveController - commented on a task
- PhabricatorProjectProfileController - viewed project with id of 1 that has a few tasks in it
- PhabricatorSearchAttachController - merged tasks together
- DifferentialTransactionEditor - submit a diff that references a task; commit the diff (thus closing the diff) and the task gets updated
- PhabricatorRepositoryCommitMessageParserWorker - submit a diff that references a task; commit the diff (thus closing the diff) and the task gets updated
=== Calls sites where *did not* add needProjectPHIDs (they do not appear in this revision) ===
- PhabricatorManiphestApplication - loaded the home page
- ManiphestGetTaskTransactionsConduitAPIMethod - used the method via conduit console with input ids : [1, 2] ManiphestTaskDetailController - viewed a task with and without associated projects; finished workflow creating a task with a parent
- ManiphestTransactionPreviewController - verified transaction preview showed up properly
- PhabricatorProjectBoardViewController - viewed a board
- PhabricatorProjectMoveController - moved a task around
- ManiphestRemarkupRule - made a task reference like {T123}
- ManiphestTaskQuery - executed a custom query for all tasks with page size of 2 and paginated through some tasks
- ManiphestTaskPHIDType - nothing random seems broken? =D
=== Call sites where had to do something funky ===
- ManiphestHovercardEventListener - loaded hover cards from task mentions
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T5245
Differential Revision: https://secure.phabricator.com/D11004
420 lines
11 KiB
PHP
420 lines
11 KiB
PHP
<?php
|
|
|
|
final class PhabricatorHomeMainController extends PhabricatorHomeController {
|
|
|
|
private $only;
|
|
private $minipanels = array();
|
|
|
|
public function shouldAllowPublic() {
|
|
return true;
|
|
}
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->only = idx($data, 'only');
|
|
}
|
|
|
|
public function processRequest() {
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
$dashboard = PhabricatorDashboardInstall::getDashboard(
|
|
$user,
|
|
$user->getPHID(),
|
|
get_class($this->getCurrentApplication()));
|
|
|
|
if (!$dashboard) {
|
|
$dashboard = PhabricatorDashboardInstall::getDashboard(
|
|
$user,
|
|
PhabricatorHomeApplication::DASHBOARD_DEFAULT,
|
|
get_class($this->getCurrentApplication()));
|
|
}
|
|
|
|
if ($dashboard) {
|
|
$content = id(new PhabricatorDashboardRenderingEngine())
|
|
->setViewer($user)
|
|
->setDashboard($dashboard)
|
|
->renderDashboard();
|
|
} else {
|
|
$project_query = new PhabricatorProjectQuery();
|
|
$project_query->setViewer($user);
|
|
$project_query->withMemberPHIDs(array($user->getPHID()));
|
|
$projects = $project_query->execute();
|
|
|
|
$content = $this->buildMainResponse($projects);
|
|
}
|
|
|
|
if (!$this->only) {
|
|
$nav = $this->buildNav();
|
|
$nav->appendChild(
|
|
array(
|
|
$content,
|
|
id(new PhabricatorGlobalUploadTargetView())->setUser($user),
|
|
));
|
|
$content = $nav;
|
|
}
|
|
|
|
return $this->buildApplicationPage(
|
|
$content,
|
|
array(
|
|
'title' => 'Phabricator',
|
|
));
|
|
}
|
|
|
|
private function buildMainResponse(array $projects) {
|
|
assert_instances_of($projects, 'PhabricatorProject');
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$has_maniphest = PhabricatorApplication::isClassInstalledForViewer(
|
|
'PhabricatorManiphestApplication',
|
|
$viewer);
|
|
|
|
$has_audit = PhabricatorApplication::isClassInstalledForViewer(
|
|
'PhabricatorAuditApplication',
|
|
$viewer);
|
|
|
|
$has_differential = PhabricatorApplication::isClassInstalledForViewer(
|
|
'PhabricatorDifferentialApplication',
|
|
$viewer);
|
|
|
|
if ($has_maniphest) {
|
|
$unbreak_panel = $this->buildUnbreakNowPanel();
|
|
$triage_panel = $this->buildNeedsTriagePanel($projects);
|
|
$tasks_panel = $this->buildTasksPanel();
|
|
} else {
|
|
$unbreak_panel = null;
|
|
$triage_panel = null;
|
|
$tasks_panel = null;
|
|
}
|
|
|
|
if ($has_audit) {
|
|
$audit_panel = $this->buildAuditPanel();
|
|
$commit_panel = $this->buildCommitPanel();
|
|
} else {
|
|
$audit_panel = null;
|
|
$commit_panel = null;
|
|
}
|
|
|
|
if (PhabricatorEnv::getEnvConfig('welcome.html') !== null) {
|
|
$welcome_panel = $this->buildWelcomePanel();
|
|
} else {
|
|
$welcome_panel = null;
|
|
}
|
|
|
|
if ($has_differential) {
|
|
$revision_panel = $this->buildRevisionPanel();
|
|
} else {
|
|
$revision_panel = null;
|
|
}
|
|
|
|
return array(
|
|
$welcome_panel,
|
|
$unbreak_panel,
|
|
$triage_panel,
|
|
$revision_panel,
|
|
$tasks_panel,
|
|
$audit_panel,
|
|
$commit_panel,
|
|
$this->minipanels,
|
|
);
|
|
}
|
|
|
|
private function buildUnbreakNowPanel() {
|
|
$unbreak_now = PhabricatorEnv::getEnvConfig(
|
|
'maniphest.priorities.unbreak-now');
|
|
if (!$unbreak_now) {
|
|
return null;
|
|
}
|
|
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
$task_query = id(new ManiphestTaskQuery())
|
|
->setViewer($user)
|
|
->withStatuses(ManiphestTaskStatus::getOpenStatusConstants())
|
|
->withPriorities(array($unbreak_now))
|
|
->needProjectPHIDs(true)
|
|
->setLimit(10);
|
|
|
|
$tasks = $task_query->execute();
|
|
|
|
if (!$tasks) {
|
|
return $this->renderMiniPanel(
|
|
'No "Unbreak Now!" Tasks',
|
|
'Nothing appears to be critically broken right now.');
|
|
}
|
|
|
|
$href = urisprintf(
|
|
'/maniphest/?statuses=%s&priorities=%s#R',
|
|
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
|
|
$unbreak_now);
|
|
$title = pht('Unbreak Now!');
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader($this->renderSectionHeader($title, $href));
|
|
$panel->appendChild($this->buildTaskListView($tasks));
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
private function buildNeedsTriagePanel(array $projects) {
|
|
assert_instances_of($projects, 'PhabricatorProject');
|
|
|
|
$needs_triage = PhabricatorEnv::getEnvConfig(
|
|
'maniphest.priorities.needs-triage');
|
|
if (!$needs_triage) {
|
|
return null;
|
|
}
|
|
|
|
$user = $this->getRequest()->getUser();
|
|
if (!$user->isLoggedIn()) {
|
|
return null;
|
|
}
|
|
|
|
if ($projects) {
|
|
$task_query = id(new ManiphestTaskQuery())
|
|
->setViewer($user)
|
|
->withStatuses(ManiphestTaskStatus::getOpenStatusConstants())
|
|
->withPriorities(array($needs_triage))
|
|
->withAnyProjects(mpull($projects, 'getPHID'))
|
|
->needProjectPHIDs(true)
|
|
->setLimit(10);
|
|
$tasks = $task_query->execute();
|
|
} else {
|
|
$tasks = array();
|
|
}
|
|
|
|
if (!$tasks) {
|
|
return $this->renderMiniPanel(
|
|
'No "Needs Triage" Tasks',
|
|
hsprintf(
|
|
'No tasks in <a href="/project/">projects you are a member of</a> '.
|
|
'need triage.'));
|
|
}
|
|
|
|
$title = pht('Needs Triage');
|
|
$href = urisprintf(
|
|
'/maniphest/?statuses=%s&priorities=%s&userProjects=%s#R',
|
|
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
|
|
$needs_triage,
|
|
$user->getPHID());
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader($this->renderSectionHeader($title, $href));
|
|
$panel->appendChild($this->buildTaskListView($tasks));
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
private function buildRevisionPanel() {
|
|
$user = $this->getRequest()->getUser();
|
|
$user_phid = $user->getPHID();
|
|
|
|
$revision_query = id(new DifferentialRevisionQuery())
|
|
->setViewer($user)
|
|
->withStatus(DifferentialRevisionQuery::STATUS_OPEN)
|
|
->withResponsibleUsers(array($user_phid))
|
|
->needRelationships(true)
|
|
->needFlags(true)
|
|
->needDrafts(true);
|
|
|
|
$revisions = $revision_query->execute();
|
|
|
|
list($blocking, $active, ) = DifferentialRevisionQuery::splitResponsible(
|
|
$revisions,
|
|
array($user_phid));
|
|
|
|
if (!$blocking && !$active) {
|
|
return $this->renderMiniPanel(
|
|
'No Waiting Revisions',
|
|
'No revisions are waiting on you.');
|
|
}
|
|
|
|
$title = pht('Revisions Waiting on You');
|
|
$href = '/differential';
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader($this->renderSectionHeader($title, $href));
|
|
|
|
$revision_view = id(new DifferentialRevisionListView())
|
|
->setHighlightAge(true)
|
|
->setRevisions(array_merge($blocking, $active))
|
|
->setUser($user);
|
|
$phids = array_merge(
|
|
array($user_phid),
|
|
$revision_view->getRequiredHandlePHIDs());
|
|
$handles = $this->loadViewerHandles($phids);
|
|
|
|
$revision_view->setHandles($handles);
|
|
|
|
$list_view = $revision_view->render();
|
|
$list_view->setFlush(true);
|
|
|
|
$panel->appendChild($list_view);
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
private function buildWelcomePanel() {
|
|
$panel = new AphrontPanelView();
|
|
$panel->appendChild(
|
|
phutil_safe_html(
|
|
PhabricatorEnv::getEnvConfig('welcome.html')));
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
private function buildTasksPanel() {
|
|
$user = $this->getRequest()->getUser();
|
|
$user_phid = $user->getPHID();
|
|
|
|
$task_query = id(new ManiphestTaskQuery())
|
|
->setViewer($user)
|
|
->withStatuses(ManiphestTaskStatus::getOpenStatusConstants())
|
|
->setGroupBy(ManiphestTaskQuery::GROUP_PRIORITY)
|
|
->withOwners(array($user_phid))
|
|
->needProjectPHIDs(true)
|
|
->setLimit(10);
|
|
|
|
$tasks = $task_query->execute();
|
|
|
|
|
|
if (!$tasks) {
|
|
return $this->renderMiniPanel(
|
|
'No Assigned Tasks',
|
|
'You have no assigned tasks.');
|
|
}
|
|
|
|
$title = pht('Assigned Tasks');
|
|
$href = '/maniphest';
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader($this->renderSectionHeader($title, $href));
|
|
$panel->appendChild($this->buildTaskListView($tasks));
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
private function buildTaskListView(array $tasks) {
|
|
assert_instances_of($tasks, 'ManiphestTask');
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
$phids = array_merge(
|
|
array_filter(mpull($tasks, 'getOwnerPHID')),
|
|
array_mergev(mpull($tasks, 'getProjectPHIDs')));
|
|
|
|
$handles = $this->loadViewerHandles($phids);
|
|
|
|
$view = new ManiphestTaskListView();
|
|
$view->setTasks($tasks);
|
|
$view->setUser($user);
|
|
$view->setHandles($handles);
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function renderSectionHeader($title, $href) {
|
|
$header = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
),
|
|
$title);
|
|
return $header;
|
|
}
|
|
|
|
private function renderMiniPanel($title, $body) {
|
|
$panel = new AphrontMiniPanelView();
|
|
$panel->appendChild(
|
|
phutil_tag(
|
|
'p',
|
|
array(
|
|
),
|
|
array(
|
|
phutil_tag('strong', array(), $title.': '),
|
|
$body,
|
|
)));
|
|
$this->minipanels[] = $panel;
|
|
}
|
|
|
|
public function buildAuditPanel() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$phids = PhabricatorAuditCommentEditor::loadAuditPHIDsForUser($user);
|
|
|
|
$query = id(new DiffusionCommitQuery())
|
|
->setViewer($user)
|
|
->withAuditorPHIDs($phids)
|
|
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_OPEN)
|
|
->withAuditAwaitingUser($user)
|
|
->needAuditRequests(true)
|
|
->needCommitData(true)
|
|
->setLimit(10);
|
|
|
|
$commits = $query->execute();
|
|
|
|
if (!$commits) {
|
|
return $this->renderMinipanel(
|
|
'No Audits',
|
|
'No commits are waiting for you to audit them.');
|
|
}
|
|
|
|
$view = id(new PhabricatorAuditListView())
|
|
->setCommits($commits)
|
|
->setUser($user);
|
|
|
|
$phids = $view->getRequiredHandlePHIDs();
|
|
$handles = $this->loadViewerHandles($phids);
|
|
$view->setHandles($handles);
|
|
|
|
$title = pht('Audits');
|
|
$href = '/audit/';
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader($this->renderSectionHeader($title, $href));
|
|
$panel->appendChild($view);
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
public function buildCommitPanel() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$phids = array($user->getPHID());
|
|
|
|
$query = id(new DiffusionCommitQuery())
|
|
->setViewer($user)
|
|
->withAuthorPHIDs($phids)
|
|
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_CONCERN)
|
|
->needCommitData(true)
|
|
->needAuditRequests(true)
|
|
->setLimit(10);
|
|
|
|
$commits = $query->execute();
|
|
|
|
if (!$commits) {
|
|
return $this->renderMinipanel(
|
|
'No Problem Commits',
|
|
'No one has raised concerns with your commits.');
|
|
}
|
|
|
|
$view = id(new PhabricatorAuditListView())
|
|
->setCommits($commits)
|
|
->setUser($user);
|
|
|
|
$phids = $view->getRequiredHandlePHIDs();
|
|
$handles = $this->loadViewerHandles($phids);
|
|
$view->setHandles($handles);
|
|
|
|
$title = pht('Problem Commits');
|
|
$href = '/audit/';
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader($this->renderSectionHeader($title, $href));
|
|
$panel->appendChild($view);
|
|
$panel->setNoBackground();
|
|
|
|
return $panel;
|
|
}
|
|
|
|
}
|