8aa8ef49da
Summary: Ref T1279. These reviewers don't actually create a logical block yet (that is, revisions still transition to "accepted" even in their presence), but this handles everything except that. Test Plan: Added Herald rules and updated revisions; see screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1279 Differential Revision: https://secure.phabricator.com/D7244
103 lines
2.7 KiB
PHP
103 lines
2.7 KiB
PHP
<?php
|
|
|
|
final class DifferentialReviewersView extends AphrontView {
|
|
|
|
private $reviewers;
|
|
private $handles;
|
|
private $diff;
|
|
|
|
public function setReviewers(array $reviewers) {
|
|
assert_instances_of($reviewers, 'DifferentialReviewer');
|
|
$this->reviewers = $reviewers;
|
|
return $this;
|
|
}
|
|
|
|
public function setHandles(array $handles) {
|
|
assert_instances_of($handles, 'PhabricatorObjectHandle');
|
|
$this->handles = $handles;
|
|
return $this;
|
|
}
|
|
|
|
public function setActiveDiff(DifferentialDiff $diff) {
|
|
$this->diff = $diff;
|
|
return $this;
|
|
}
|
|
|
|
public function render() {
|
|
$viewer = $this->getUser();
|
|
|
|
$view = new PHUIStatusListView();
|
|
foreach ($this->reviewers as $reviewer) {
|
|
$phid = $reviewer->getReviewerPHID();
|
|
$handle = $this->handles[$phid];
|
|
|
|
// If we're missing either the diff or action information for the
|
|
// reviewer, render information as current.
|
|
$is_current = (!$this->diff) ||
|
|
(!$reviewer->getDiffID()) ||
|
|
($this->diff->getID() == $reviewer->getDiffID());
|
|
|
|
$item = new PHUIStatusItemView();
|
|
|
|
$item->setHighlighted($reviewer->hasAuthority($viewer));
|
|
|
|
switch ($reviewer->getStatus()) {
|
|
case DifferentialReviewerStatus::STATUS_ADDED:
|
|
$item->setIcon('open-dark', pht('Review Requested'));
|
|
break;
|
|
|
|
case DifferentialReviewerStatus::STATUS_ACCEPTED:
|
|
if ($is_current) {
|
|
$item->setIcon(
|
|
'accept-green',
|
|
pht('Accepted'));
|
|
} else {
|
|
$item->setIcon(
|
|
'accept-dark',
|
|
pht('Accepted Prior Diff'));
|
|
}
|
|
break;
|
|
|
|
case DifferentialReviewerStatus::STATUS_REJECTED:
|
|
if ($is_current) {
|
|
$item->setIcon(
|
|
'reject-red',
|
|
pht('Requested Changes'));
|
|
} else {
|
|
$item->setIcon(
|
|
'reject-dark',
|
|
pht('Requested Changes to Prior Diff'));
|
|
}
|
|
break;
|
|
|
|
case DifferentialReviewerStatus::STATUS_COMMENTED:
|
|
if ($is_current) {
|
|
$item->setIcon(
|
|
'info-blue',
|
|
pht('Commented'));
|
|
} else {
|
|
$item->setIcon(
|
|
'info-dark',
|
|
pht('Commented Previously'));
|
|
}
|
|
break;
|
|
|
|
case DifferentialReviewerStatus::STATUS_BLOCKING:
|
|
$item->setIcon('minus-red', pht('Blocking Review'));
|
|
break;
|
|
|
|
default:
|
|
$item->setIcon('question-dark', pht('%s?', $reviewer->getStatus()));
|
|
break;
|
|
|
|
}
|
|
|
|
$item->setTarget($handle->renderLink());
|
|
$view->addItem($item);
|
|
}
|
|
|
|
return $view;
|
|
}
|
|
|
|
}
|