a4e8fd2289
Summary: Ref T2230. Very rarely, even though we've flushed the connection and sent all the data, we'll close the connection before Git is happy with it and it will flip out with an error like this: fatal: The remote end hung up unexpectedly fatal: early EOF fatal: index-pack failed This is hard to reproduce because it depends on the order of read/write operations we can't directly control. I only saw it about 2% of the time, by just running `git pull` over and over again. Waiting for Git to close its side of the connection seems to fix it. Test Plan: Ran `git clone` a ton of times without seeing the error again. Ran `git push` a ton of times with new commits. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2230 Differential Revision: https://secure.phabricator.com/D7558
37 lines
793 B
PHP
37 lines
793 B
PHP
<?php
|
|
|
|
final class DiffusionSSHGitUploadPackWorkflow
|
|
extends DiffusionSSHGitWorkflow {
|
|
|
|
public function didConstruct() {
|
|
$this->setName('git-upload-pack');
|
|
$this->setArguments(
|
|
array(
|
|
array(
|
|
'name' => 'dir',
|
|
'wildcard' => true,
|
|
),
|
|
));
|
|
}
|
|
|
|
protected function executeRepositoryOperations() {
|
|
$args = $this->getArgs();
|
|
$path = head($args->getArg('dir'));
|
|
$repository = $this->loadRepository($path);
|
|
|
|
$future = new ExecFuture('git-upload-pack %s', $repository->getLocalPath());
|
|
|
|
$err = $this->newPassthruCommand()
|
|
->setIOChannel($this->getIOChannel())
|
|
->setCommandChannelFromExecFuture($future)
|
|
->execute();
|
|
|
|
if (!$err) {
|
|
$this->waitForGitClient();
|
|
}
|
|
|
|
return $err;
|
|
}
|
|
|
|
}
|