b592630d72
Summary: Three changes here. - Add `setActionList()`, and use that to set the action list. - Add `setPropertyList()`, and use that to set the property list. These will let us add some apropriate CSS so we can fix the border issue, and get rid of a bunch of goofy `.x + .y` selectors. - Replace `addContent()` with `appendChild()`. This is just a consistency thing; `AphrontView` already provides `appendChild()`, and `addContent()` did the same thing. Test Plan: - Viewed "All Config". - Viewed a countdown. - Viewed a revision (add comment, change list, table of contents, comment, local commits, open revisions affecting these files, update history). - Viewed Diffusion (browse, change, history, repository, lint). - Viewed Drydock (resource, lease). - Viewed Files. - Viewed Herald. - Viewed Legalpad. - Viewed macro (edit, edit audio, view). - Viewed Maniphest. - Viewed Applications. - Viewed Paste. - Viewed People. - Viewed Phulux. - Viewed Pholio. - Viewed Phame (blog, post). - Viewed Phortune (account, product). - Viewed Ponder (questions, answers, comments). - Viewed Releeph. - Viewed Projects. - Viewed Slowvote. NOTE: Images in Files aren't on a black background anymore -- I assume that's on purpose? NOTE: Some jankiness in Phortune, I'll clean that up when I get back to it. Not related to this diff. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D7174
117 lines
2.9 KiB
PHP
117 lines
2.9 KiB
PHP
<?php
|
|
|
|
final class HeraldRuleViewController extends HeraldController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$rule = id(new HeraldRuleQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($this->id))
|
|
->needConditionsAndActions(true)
|
|
->executeOne();
|
|
if (!$rule) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setHeader($rule->getName());
|
|
|
|
$actions = $this->buildActionView($rule);
|
|
$properties = $this->buildPropertyView($rule);
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht('Rule %d', $rule->getID())));
|
|
|
|
$object_box = id(new PHUIObjectBoxView())
|
|
->setHeader($header)
|
|
->setActionList($actions)
|
|
->setPropertyList($properties);
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$object_box,
|
|
),
|
|
array(
|
|
'title' => $rule->getName(),
|
|
'device' => true,
|
|
));
|
|
}
|
|
|
|
private function buildActionView(HeraldRule $rule) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
$id = $rule->getID();
|
|
|
|
$view = id(new PhabricatorActionListView())
|
|
->setUser($viewer)
|
|
->setObject($rule)
|
|
->setObjectURI($this->getApplicationURI("rule/{$id}/"));
|
|
|
|
$can_edit = PhabricatorPolicyFilter::hasCapability(
|
|
$viewer,
|
|
$rule,
|
|
PhabricatorPolicyCapability::CAN_EDIT);
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Edit Rule'))
|
|
->setHref($this->getApplicationURI("edit/{$id}/"))
|
|
->setIcon('edit')
|
|
->setDisabled(!$can_edit)
|
|
->setWorkflow(!$can_edit));
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function buildPropertyView(HeraldRule $rule) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$this->loadHandles(HeraldAdapter::getHandlePHIDs($rule));
|
|
|
|
$view = id(new PhabricatorPropertyListView())
|
|
->setUser($viewer)
|
|
->setObject($rule);
|
|
|
|
$view->addProperty(
|
|
pht('Rule Type'),
|
|
idx(HeraldRuleTypeConfig::getRuleTypeMap(), $rule->getRuleType()));
|
|
|
|
if ($rule->isPersonalRule()) {
|
|
$view->addProperty(
|
|
pht('Author'),
|
|
$this->getHandle($rule->getAuthorPHID())->renderLink());
|
|
}
|
|
|
|
$adapter = HeraldAdapter::getAdapterForContentType($rule->getContentType());
|
|
if ($adapter) {
|
|
$view->addProperty(
|
|
pht('Applies To'),
|
|
idx(HeraldAdapter::getEnabledAdapterMap(), $rule->getContentType()));
|
|
|
|
$view->invokeWillRenderEvent();
|
|
|
|
$view->addSectionHeader(pht('Rule Description'));
|
|
$view->addTextContent(
|
|
phutil_tag(
|
|
'div',
|
|
array(
|
|
'style' => 'white-space: pre-wrap;',
|
|
),
|
|
$adapter->renderRuleAsText($rule, $this->getLoadedHandles())));
|
|
}
|
|
|
|
return $view;
|
|
}
|
|
|
|
}
|