bd17fac935
Summary: Ref T3092. Fixes T3724. Use modern/flexible UI for these interfaces. Removes the ability to retarget an existing branch (you can just close it and open a new one if you made a mistake).
Test Plan: {F54437} {F54438}
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3092, T3724
Differential Revision: https://secure.phabricator.com/D6765
119 lines
3.5 KiB
PHP
119 lines
3.5 KiB
PHP
<?php
|
|
|
|
final class ReleephBranchCreateController extends ReleephProjectController {
|
|
|
|
public function processRequest() {
|
|
$releeph_project = $this->getReleephProject();
|
|
|
|
$request = $this->getRequest();
|
|
|
|
$cut_point = $request->getStr('cutPoint');
|
|
$symbolic_name = $request->getStr('symbolicName');
|
|
|
|
if (!$cut_point) {
|
|
$repository = $releeph_project->loadPhabricatorRepository();
|
|
switch ($repository->getVersionControlSystem()) {
|
|
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
|
|
break;
|
|
|
|
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
|
|
$cut_point = $releeph_project->getTrunkBranch();
|
|
break;
|
|
}
|
|
}
|
|
|
|
$e_cut = true;
|
|
$errors = array();
|
|
|
|
$branch_date_control = id(new AphrontFormDateControl())
|
|
->setUser($request->getUser())
|
|
->setName('templateDate')
|
|
->setLabel(pht('Date'))
|
|
->setCaption(pht('The date used for filling out the branch template.'))
|
|
->setInitialTime(AphrontFormDateControl::TIME_START_OF_DAY);
|
|
$branch_date = $branch_date_control->readValueFromRequest($request);
|
|
|
|
if ($request->isFormPost()) {
|
|
$cut_commit = null;
|
|
if (!$cut_point) {
|
|
$e_cut = pht('Required');
|
|
$errors[] = pht('You must give a branch cut point');
|
|
} else {
|
|
try {
|
|
$finder = id(new ReleephCommitFinder())
|
|
->setUser($request->getUser())
|
|
->setReleephProject($releeph_project);
|
|
$cut_commit = $finder->fromPartial($cut_point);
|
|
} catch (Exception $e) {
|
|
$e_cut = pht('Invalid');
|
|
$errors[] = $e->getMessage();
|
|
}
|
|
}
|
|
|
|
if (!$errors) {
|
|
$branch = id(new ReleephBranchEditor())
|
|
->setReleephProject($releeph_project)
|
|
->setActor($request->getUser())
|
|
->newBranchFromCommit(
|
|
$cut_commit,
|
|
$branch_date,
|
|
$symbolic_name);
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI($branch->getURI());
|
|
}
|
|
}
|
|
|
|
$error_view = array();
|
|
if ($errors) {
|
|
$error_view = new AphrontErrorView();
|
|
$error_view->setErrors($errors);
|
|
$error_view->setTitle(pht('Form Errors'));
|
|
}
|
|
|
|
$project_id = $releeph_project->getID();
|
|
$project_uri = $this->getApplicationURI("project/{$project_id}/");
|
|
|
|
$form = id(new AphrontFormView())
|
|
->setUser($request->getUser())
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Symbolic Name'))
|
|
->setName('symbolicName')
|
|
->setValue($symbolic_name)
|
|
->setCaption(pht('Mutable alternate name, for easy reference, '.
|
|
'(e.g. "LATEST")')))
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Cut point'))
|
|
->setName('cutPoint')
|
|
->setValue($cut_point)
|
|
->setError($e_cut)
|
|
->setCaption(
|
|
pht('A commit ID for your repo type, or a '.
|
|
'Diffusion ID like "rE123"')))
|
|
->appendChild($branch_date_control)
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue(pht('Cut Branch'))
|
|
->addCancelButton($project_uri));
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht('New Branch')));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$error_view,
|
|
$form,
|
|
),
|
|
array(
|
|
'title' => pht('New Branch'),
|
|
'device' => true,
|
|
'dust' => true,
|
|
));
|
|
}
|
|
}
|