c1f1345cc0
Summary:
Ref T13513. Improve consistency and robustness of the "InlineComment" queries.
The only real change here is that these queries now implicitly add a clause for selecting inlines ("pathID IS NULL" or "changesetID IS NULL").
Test Plan: Browed, created, edited, and submitted inlines.
Maniphest Tasks: T13513
Differential Revision: https://secure.phabricator.com/D21227
83 lines
2.1 KiB
PHP
83 lines
2.1 KiB
PHP
<?php
|
|
|
|
abstract class PhabricatorDiffInlineCommentQuery
|
|
extends PhabricatorApplicationTransactionCommentQuery {
|
|
|
|
private $fixedStates;
|
|
private $needReplyToComments;
|
|
|
|
abstract protected function buildInlineCommentWhereClauseParts(
|
|
AphrontDatabaseConnection $conn);
|
|
abstract public function withObjectPHIDs(array $phids);
|
|
|
|
public function withFixedStates(array $states) {
|
|
$this->fixedStates = $states;
|
|
return $this;
|
|
}
|
|
|
|
public function needReplyToComments($need_reply_to) {
|
|
$this->needReplyToComments = $need_reply_to;
|
|
return $this;
|
|
}
|
|
|
|
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
|
|
$where = parent::buildWhereClauseParts($conn);
|
|
$alias = $this->getPrimaryTableAlias();
|
|
|
|
foreach ($this->buildInlineCommentWhereClauseParts($conn) as $part) {
|
|
$where[] = $part;
|
|
}
|
|
|
|
if ($this->fixedStates !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'%T.fixedState IN (%Ls)',
|
|
$alias,
|
|
$this->fixedStates);
|
|
}
|
|
|
|
return $where;
|
|
}
|
|
|
|
protected function willFilterPage(array $comments) {
|
|
if ($this->needReplyToComments) {
|
|
$reply_phids = array();
|
|
foreach ($comments as $comment) {
|
|
$reply_phid = $comment->getReplyToCommentPHID();
|
|
if ($reply_phid) {
|
|
$reply_phids[] = $reply_phid;
|
|
}
|
|
}
|
|
|
|
if ($reply_phids) {
|
|
$reply_comments = newv(get_class($this), array())
|
|
->setViewer($this->getViewer())
|
|
->setParentQuery($this)
|
|
->withPHIDs($reply_phids)
|
|
->execute();
|
|
$reply_comments = mpull($reply_comments, null, 'getPHID');
|
|
} else {
|
|
$reply_comments = array();
|
|
}
|
|
|
|
foreach ($comments as $key => $comment) {
|
|
$reply_phid = $comment->getReplyToCommentPHID();
|
|
if (!$reply_phid) {
|
|
$comment->attachReplyToComment(null);
|
|
continue;
|
|
}
|
|
$reply = idx($reply_comments, $reply_phid);
|
|
if (!$reply) {
|
|
$this->didRejectResult($comment);
|
|
unset($comments[$key]);
|
|
continue;
|
|
}
|
|
$comment->attachReplyToComment($reply);
|
|
}
|
|
}
|
|
|
|
return $comments;
|
|
}
|
|
|
|
}
|