Summary: Ref T603. This swaps almost all queries against the repository table over to be policy aware. Test Plan: - Made an audit comment on a commit. - Ran `save_lint.php`. - Looked up a commit with `diffusion.getcommits`. - Looked up lint messages with `diffusion.getlintmessages`. - Clicked an external/submodule in Diffusion. - Viewed main lint and repository lint in Diffusion. - Completed and validated Owners paths in Owners. - Executed dry runs via Herald. - Queried for package owners with `owners.query`. - Viewed Owners package. - Edited Owners package. - Viewed Owners package list. - Executed `repository.query`. - Viewed "Repository" tool repository list. - Edited Arcanist project. - Hit "Delete" on repository (this just tells you to use the CLI). - Created a repository. - Edited a repository. - Ran `bin/repository list`. - Ran `bin/search index rGTESTff45d13dffcfb3ea85b03aac8cc36251cacdf01c` - Pushed and parsed a commit. - Skipped all the Drydock stuff, as it it's hard to test and isn't normally reachable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7132
126 lines
3.6 KiB
PHP
126 lines
3.6 KiB
PHP
<?php
|
|
|
|
final class HeraldTestConsoleController extends HeraldController {
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$request = $this->getRequest();
|
|
|
|
$object_name = trim($request->getStr('object_name'));
|
|
|
|
$e_name = true;
|
|
$errors = array();
|
|
if ($request->isFormPost()) {
|
|
if (!$object_name) {
|
|
$e_name = pht('Required');
|
|
$errors[] = pht('An object name is required.');
|
|
}
|
|
|
|
if (!$errors) {
|
|
$object = id(new PhabricatorObjectQuery())
|
|
->setViewer($user)
|
|
->withNames(array($object_name))
|
|
->executeOne();
|
|
|
|
if (!$object) {
|
|
$e_name = pht('Invalid');
|
|
$errors[] = pht('No object exists with that name.');
|
|
}
|
|
|
|
if (!$errors) {
|
|
if ($object instanceof DifferentialRevision) {
|
|
$adapter = HeraldDifferentialRevisionAdapter::newLegacyAdapter(
|
|
$object,
|
|
$object->loadActiveDiff());
|
|
} else if ($object instanceof PhabricatorRepositoryCommit) {
|
|
$data = id(new PhabricatorRepositoryCommitData())->loadOneWhere(
|
|
'commitID = %d',
|
|
$object->getID());
|
|
$adapter = HeraldCommitAdapter::newLegacyAdapter(
|
|
$object->getRepository(),
|
|
$object,
|
|
$data);
|
|
} else {
|
|
throw new Exception("Can not build adapter for object!");
|
|
}
|
|
|
|
$rules = id(new HeraldRuleQuery())
|
|
->setViewer($user)
|
|
->withContentTypes(array($adapter->getAdapterContentType()))
|
|
->needConditionsAndActions(true)
|
|
->needAppliedToPHIDs(array($object->getPHID()))
|
|
->needValidateAuthors(true)
|
|
->execute();
|
|
|
|
$engine = id(new HeraldEngine())
|
|
->setDryRun(true);
|
|
|
|
$effects = $engine->applyRules($rules, $adapter);
|
|
$engine->applyEffects($effects, $adapter, $rules);
|
|
|
|
$xscript = $engine->getTranscript();
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI('/herald/transcript/'.$xscript->getID().'/');
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($errors) {
|
|
$error_view = new AphrontErrorView();
|
|
$error_view->setTitle(pht('Form Errors'));
|
|
$error_view->setErrors($errors);
|
|
} else {
|
|
$error_view = null;
|
|
}
|
|
|
|
$text = pht('Enter an object to test rules '.
|
|
'for, like a Diffusion commit (e.g., rX123) or a '.
|
|
'Differential revision (e.g., D123). You will be shown the '.
|
|
'results of a dry run on the object.');
|
|
|
|
$form = id(new AphrontFormView())
|
|
->setUser($user)
|
|
->appendChild(hsprintf(
|
|
'<p class="aphront-form-instructions">%s</p>', $text))
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Object Name'))
|
|
->setName('object_name')
|
|
->setError($e_name)
|
|
->setValue($object_name))
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue(pht('Test Rules')));
|
|
|
|
$nav = $this->buildSideNavView();
|
|
$nav->selectFilter('test');
|
|
$nav->appendChild(
|
|
array(
|
|
$error_view,
|
|
$form,
|
|
));
|
|
|
|
$crumbs = id($this->buildApplicationCrumbs())
|
|
->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht('Transcripts'))
|
|
->setHref($this->getApplicationURI('/transcript/')))
|
|
->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName(pht('Test Console')));
|
|
$nav->setCrumbs($crumbs);
|
|
|
|
return $this->buildApplicationPage(
|
|
$nav,
|
|
array(
|
|
'title' => pht('Test Console'),
|
|
'device' => true,
|
|
));
|
|
}
|
|
|
|
}
|